From: Dan Nicolaescu <dann@ics.uci.edu>
To: Reto Zimmermann <Reto.Zimmermann@synopsys.com>
Cc: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: vera-mode.el
Date: Sun, 10 Jun 2007 09:08:21 -0700 [thread overview]
Message-ID: <200706101608.l5AG8MLL007414@oogie-boogie.ics.uci.edu> (raw)
In-Reply-To: <4667F51D.5060707@synopsys.com> (Reto Zimmermann's message of "Thu\, 07 Jun 2007 14\:07\:57 +0200")
Reto Zimmermann <Reto.Zimmermann@synopsys.com> writes:
> Dan Nicolaescu wrote:
>
> > Thanks for submitting this code!
> >
> > Reto Zimmermann <Reto.Zimmermann@synopsys.com> writes:
> >
> >
> > > (defface vera-font-lock-number-face
> >
> > Faces don't have "-face" suffix anymore now, some face names have been
> > kept for compatibility, but it would be good not to introduce new
> > ones.
For this you'd need to do something like:
(defface vera-font-lock-number-face
...
...)
(put 'vera-font-lock-number 'face-alias 'vera-font-lock-number-face)
> >
> > > (defface vera-font-lock-function-face
> >
> > Any reason you are not using font-lock-function-name-face here?
> >
> > font-lock is on by default in emacs-22, so there's a set of 15
> > predefined faces that you could use.
> >
> > Can you use the predefined font-lock faces for any of the faces that
> > vera-mode uses?
>
> I added these faces because I wanted even more colors do distinguish
> different language elements and I didn't find appropriate colors in
> the predefined faces. I am already using font-lock-function-name-face
> for something else. So I would like to keep these additional colors
> because it was a user wish.
Note that my code was not an objection in any way, just making sure
that there's a good reason for adding these faces, and there is.
What is the next step? IMHO this code is ready to be checked in.
next prev parent reply other threads:[~2007-06-10 16:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1HveXE-00080m-T4@fencepost.gnu.org>
[not found] ` <4665C2DC.3090102@synopsys.com>
[not found] ` <E1HvyqV-0003IZ-Fj@fencepost.gnu.org>
2007-06-06 17:14 ` vera-mode.el Reto Zimmermann
2007-06-06 18:03 ` vera-mode.el Stefan Monnier
2007-06-06 21:30 ` vera-mode.el Reto Zimmermann
2007-06-06 23:38 ` vera-mode.el Dan Nicolaescu
2007-06-07 12:07 ` vera-mode.el Reto Zimmermann
2007-06-10 16:08 ` Dan Nicolaescu [this message]
2007-06-11 10:52 ` vera-mode.el Reto Zimmermann
2007-06-11 11:22 ` vera-mode.el Miles Bader
2007-06-20 6:35 ` vera-mode.el Dan Nicolaescu
2007-06-20 8:22 ` vera-mode.el Reto Zimmermann
2007-06-20 7:24 ` vera-mode.el Glenn Morris
2007-06-20 8:51 ` vera-mode.el Reto Zimmermann
2007-06-07 12:35 ` vera-mode.el Stefan Monnier
2007-06-07 13:56 ` vera-mode.el Reto Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200706101608.l5AG8MLL007414@oogie-boogie.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=Reto.Zimmermann@synopsys.com \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.