From: Giorgos Keramidas <keramida@ceid.upatras.gr>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: emacs-devel@gnu.org, "Randal L. Schwartz" <merlyn@stonehenge.com>
Subject: Re: CVS HEAD fails to build
Date: Mon, 7 May 2007 23:51:41 +0300 [thread overview]
Message-ID: <20070507205140.GA95537@kobe.laptop> (raw)
In-Reply-To: <20070507195033.GA65730@kobe.laptop>
On 2007-05-07 22:50, Giorgos Keramidas <keramida@ceid.upatras.gr> wrote:
> The first bad revision is:
> changeset: 81110:6207e966040e
> user: monnier
> date: Mon May 07 15:41:37 2007 +0000
> summary: (Fdefine_key, Flookup_key): Only do the 0x80->meta_modifier
Hi Stefan and all,
this part of the change seems to be the one which is causing the
build problem:
% diff -r 62063c2fb043 -r 6207e966040e src/keymap.c
% --- a/src/keymap.c Mon May 07 08:05:55 2007 +0000
% +++ b/src/keymap.c Mon May 07 15:41:37 2007 +0000
% @@ -1312,7 +1313,7 @@ recognize the default bindings, just as
% c = Fevent_convert_list (c);
%
% /* Turn the 8th bit of string chars into a meta modifier. */
% - if (INTEGERP (c) && XINT (c) & 0x80 && STRINGP (key))
% + if (STRINGP (key) && XINT (c) & 0x8 && !STRING_MULTIBYTE (key))
% XSETINT (c, (XINT (c) | meta_modifier) & ~0x80);
%
% /* Allow string since binding for `menu-bar-select-buffer'
I have locally reverted the condition to:
if (INTEGERP (c) && XINT (c) & 0x80 && STRINGP (key) &&
!STRING_MULTIBYTE (key))
XSETINT (c, (XINT (c) | meta_modifier) & ~0x80);
but I am not sure if it matches what you originally intended to do,
Stefan. Does the new check seem reasonable?
- Giorgos
next prev parent reply other threads:[~2007-05-07 20:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-07 18:34 CVS HEAD fails to build Randal L. Schwartz
2007-05-07 18:57 ` Giorgos Keramidas
2007-05-07 19:50 ` Giorgos Keramidas
2007-05-07 20:51 ` Andreas Schwab
2007-05-07 21:03 ` Giorgos Keramidas
2007-05-07 21:03 ` Randal L. Schwartz
2007-05-07 20:51 ` Giorgos Keramidas [this message]
2007-05-07 21:41 ` Stefan Monnier
2007-05-08 18:08 ` Richard Stallman
2007-05-08 18:17 ` Stefan Monnier
2007-05-09 3:37 ` Richard Stallman
2007-05-09 10:11 ` Randal L. Schwartz
2007-05-09 13:58 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070507205140.GA95537@kobe.laptop \
--to=keramida@ceid.upatras.gr \
--cc=emacs-devel@gnu.org \
--cc=merlyn@stonehenge.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.