From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Masatake YAMATO Newsgroups: gmane.emacs.devel Subject: Re: Some problems in `add-log-current-defun' Date: Thu, 28 Dec 2006 21:41:51 +0900 (JST) Message-ID: <20061228.214151.39658002.jet@gyve.org> References: NNTP-Posting-Host: dough.gmane.org Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1167313215 32281 80.91.229.10 (28 Dec 2006 13:40:15 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 28 Dec 2006 13:40:15 +0000 (UTC) Cc: herberteuler@hotmail.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 28 14:40:13 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by dough.gmane.org with esmtp (Exim 4.50) id 1GzvUM-0000Lx-Bw for ged-emacs-devel@m.gmane.org; Thu, 28 Dec 2006 14:40:06 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GzvUL-00065k-Se for ged-emacs-devel@m.gmane.org; Thu, 28 Dec 2006 08:40:05 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GzvTN-0005bC-Px for emacs-devel@gnu.org; Thu, 28 Dec 2006 08:39:05 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GzvTL-0005Zu-VB for emacs-devel@gnu.org; Thu, 28 Dec 2006 08:39:05 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GzvTL-0005ZX-Ix for emacs-devel@gnu.org; Thu, 28 Dec 2006 08:39:03 -0500 Original-Received: from [66.187.233.31] (helo=mx1.redhat.com) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GzvTJ-0006V2-6b; Thu, 28 Dec 2006 08:39:01 -0500 Original-Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.12.11.20060308/8.12.11) with ESMTP id kBSDcuVS010299; Thu, 28 Dec 2006 08:38:56 -0500 Original-Received: from pobox.tokyo.redhat.com (pobox.tokyo.redhat.com [172.16.33.225]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id kBSDctQq029443; Thu, 28 Dec 2006 08:38:56 -0500 Original-Received: from localhost (dhcp92.tokyo.redhat.com [172.16.33.92]) by pobox.tokyo.redhat.com (8.12.8/8.12.8) with ESMTP id kBSDcovT012500; Thu, 28 Dec 2006 22:38:52 +0900 Original-To: rms@gnu.org In-Reply-To: X-Mailer: Mew version 4.2.53 on Emacs 22.0.51 / Mule 5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:64395 Archived-At: > void ssort(void * base, size_t n, size_t sz, CFT cmp) > /* > Sort the "n" elements of vector "base" into increasing order > using the comparison function pointed to by "cmp". > The elements are of size "sz". > > Shell sort (Knuth, Vol3, pg84) > */ > { > /* ... */ > } > > That seems like common usage -- not weird. It would be nice to handle > that usage correctly. However, if we have never handled it in the > past, I think it is not urgent to fix it now. > > Masatake YAMATO thinks that code is badly formatted. > Masatake, why do you think so? Just because I have never seen such a comment style. So to be exact I should write it is not badly formatted, but it is rare comment style in my experiences. Usually I have seen following comment style: /* Sort the "n" elements of vector "base" into increasing order using the comparison function pointed to by "cmp". The elements are of size "sz". Shell sort (Knuth, Vol3, pg84) */ void ssort(void * base, size_t n, size_t sz, CFT cmp) { /* ... */ } Masatake YAMATO