From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: Minor src/xmenu.c change for older GCC versions Date: Sun, 5 Nov 2006 10:00:57 +0200 Message-ID: <20061105080057.GA15931@kobe.laptop> References: <200611032150.kA3Locm0078547@kobe.laptop> <87psc328yh.fsf@stupidchicken.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1162713710 9616 80.91.229.2 (5 Nov 2006 08:01:50 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 5 Nov 2006 08:01:50 +0000 (UTC) Cc: Chong Yidong , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 05 09:01:47 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Ggcwp-0003bG-2P for ged-emacs-devel@m.gmane.org; Sun, 05 Nov 2006 09:01:43 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ggcwo-0006oy-N7 for ged-emacs-devel@m.gmane.org; Sun, 05 Nov 2006 03:01:42 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Ggcwc-0006n4-42 for emacs-devel@gnu.org; Sun, 05 Nov 2006 03:01:30 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GgcwY-0006hl-8x for emacs-devel@gnu.org; Sun, 05 Nov 2006 03:01:29 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GgcwY-0006he-5F for emacs-devel@gnu.org; Sun, 05 Nov 2006 03:01:26 -0500 Original-Received: from [62.1.205.36] (helo=igloo.linux.gr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GgcwS-0001j3-FD; Sun, 05 Nov 2006 03:01:21 -0500 Original-Received: from kobe.laptop (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-2) with ESMTP id kA5817Fi022772 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 5 Nov 2006 10:01:08 +0200 Original-Received: from kobe.laptop (kobe.laptop [127.0.0.1]) by kobe.laptop (8.13.8/8.13.8) with ESMTP id kA580xAp015958; Sun, 5 Nov 2006 10:00:59 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Original-Received: (from keramida@localhost) by kobe.laptop (8.13.8/8.13.8/Submit) id kA580viU015957; Sun, 5 Nov 2006 10:00:58 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Original-To: Richard Stallman Content-Disposition: inline In-Reply-To: X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-2.529, required 5, AWL -0.13, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61812 Archived-At: On 2006-11-05 02:07, Richard Stallman wrote: > > + FRAME_PTR f; > > + > > BLOCK_INPUT; > > - FRAME_PTR f = check_x_frame (frame); > > - > > + f = check_x_frame (frame); > > Please add a comment explaining why this is necessary, to make sure > people don't take this out for elegance's sake. Good point. Sorry I didn't add a comment originally. I thought mentioning it in the commit log would be sufficient for now :)