From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Giorgos Keramidas Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Unbreak `make install' in leim/ when leim's ${INSTALLDIR} doesn't exist Date: Thu, 12 Oct 2006 16:13:30 +0300 Message-ID: <20061012131330.GB8507@gothmog.pc> References: <549c434ebfb50d1a4ca2.1160608974@gothmog.pc> <20061012123556.GA89997@gothmog.pc> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1160658868 8878 80.91.229.2 (12 Oct 2006 13:14:28 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 12 Oct 2006 13:14:28 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 12 15:14:24 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GY0Nb-0004gZ-U1 for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 15:13:44 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GY0Nb-0007sM-8r for ged-emacs-devel@m.gmane.org; Thu, 12 Oct 2006 09:13:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GY0NK-0007oM-Oo for emacs-devel@gnu.org; Thu, 12 Oct 2006 09:13:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GY0NI-0007l5-Up for emacs-devel@gnu.org; Thu, 12 Oct 2006 09:13:26 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GY0NI-0007kf-Lx for emacs-devel@gnu.org; Thu, 12 Oct 2006 09:13:24 -0400 Original-Received: from [62.1.205.36] (helo=igloo.linux.gr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1GY0VW-0002mx-0U for emacs-devel@gnu.org; Thu, 12 Oct 2006 09:21:55 -0400 Original-Received: from gothmog.pc (host5.bedc.ondsl.gr [62.103.39.229]) (authenticated bits=128) by igloo.linux.gr (8.13.8/8.13.8/Debian-2) with ESMTP id k9CDCrBN007674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 12 Oct 2006 16:12:54 +0300 Original-Received: from gothmog.pc (gothmog [127.0.0.1]) by gothmog.pc (8.13.8/8.13.8) with ESMTP id k9CDDU1I008569; Thu, 12 Oct 2006 16:13:30 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Original-Received: (from giorgos@localhost) by gothmog.pc (8.13.8/8.13.8/Submit) id k9CDDUYA008568; Thu, 12 Oct 2006 16:13:30 +0300 (EEST) (envelope-from keramida@ceid.upatras.gr) Original-To: Kenichi Handa Content-Disposition: inline In-Reply-To: X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-2.593, required 5, AWL -0.20, BAYES_00 -2.60, DNS_FROM_RFC_ABUSE 0.20, UNPARSEABLE_RELAY 0.00) X-Hellug-MailScanner-From: keramida@ceid.upatras.gr X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60661 Archived-At: On 2006-10-12 22:10, Kenichi Handa wrote: > In article <20061012123556.GA89997@gothmog.pc>, Giorgos Keramidas writes: > > > + if [ ! -d ${INSTALLDIR} ] ; then \ > > + ${srcdir}/${dot}${dot}/mkinstalldirs ${INSTALLDIR}; \ > > + else true; fi > > Here, I just followed the coding convention of the top level > Makefile.in. > > > Apart from this minor difference, this is identical to the second > > version of the same patch I posted, > > It seems that I missed the second version somehow, sorry. > > > I will test it with a new build later today though. > > Thank you. Just finished testing. All is fine now :)