[patch] fix for the gcc -O3 miscompilation

[Jindrich Makovicka <makovick@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

Hi,

the attached patch fixes the long standing breakage when compiling
emacs with newer gcc and -O3 flag. The problem is that -O3 enables
automatic function inlining, which optimizes out the arguments for
the function invocations within eval.c and fns.c, but the functions
expect these values on stack. Adding the "noinline" attribute to these
functions used within eval.c of fns.c seems to solve the problem.

(please Cc:, I am not a subscriber)

Regards,
-- 
Jindrich Makovicka

[-- Attachment #2: inline.patch --]
[-- Type: text/x-patch, Size: 997 bytes --]

Index: eval.c
===================================================================
RCS file: /sources/emacs/emacs/src/eval.c,v
retrieving revision 1.271
diff -u -r1.271 eval.c
--- eval.c	18 Jul 2006 16:33:45 -0000	1.271
+++ eval.c	19 Aug 2006 09:20:10 -0000
@@ -199,6 +202,9 @@
 
 static Lisp_Object funcall_lambda P_ ((Lisp_Object, int, Lisp_Object*));
 static void unwind_to_catch P_ ((struct catchtag *, Lisp_Object)) NO_RETURN;
+
+Lisp_Object apply1 () __attribute__((noinline));
+Lisp_Object call2 () __attribute__((noinline));
 \f
 void
 init_eval_once ()
Index: fns.c
===================================================================
RCS file: /sources/emacs/emacs/src/fns.c,v
retrieving revision 1.413
diff -u -r1.413 fns.c
--- fns.c	26 Jul 2006 18:16:14 -0000	1.413
+++ fns.c	19 Aug 2006 09:20:11 -0000
@@ -387,7 +387,7 @@
   return i1 < SCHARS (s2) ? Qt : Qnil;
 }
 \f
-static Lisp_Object concat ();
+static Lisp_Object concat () __attribute__((noinline));
 
 /* ARGSUSED */
 Lisp_Object

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel