From: Peter Breton <peter_breton@yahoo.com>
Cc: Peter Breton <pbreton@cs.umb.edu>,
emacs-pretesters@gnu.org,
"T. V. Raman" <raman@users.sourceforge.net>
Subject: Re: Reverting *Locate* buffers.
Date: Mon, 26 Jun 2006 06:15:46 -0700 (PDT) [thread overview]
Message-ID: <20060626131546.93100.qmail@web55513.mail.re4.yahoo.com> (raw)
In-Reply-To: <200606260327.k5Q3Rfpd013691@jane.dms.auburn.edu>
That sounds fine to me.
I've never actually used the revert feature.. someone
else sent me in a patch for it, and it seemed harmless
enough so I added it. I find the idea of reverting the
buffer by rebuilding the database to be a bit odd; I
would just rerun the search, and have an additional
function to rebuild the database. However, if people
are happy with the existing feature, then it still
seems harmless to me :)
Having an additional warning when not running as root
also sounds like a good idea.
Peter
> There have been in the past several complaints about
> the fact that
> trying to revert a *Locate* buffers first asks
> whether you want to
> update the locate database.
>
> If you answer yes, then in my setup and I would
> guess in most setups,
> you get an error unless you are running as root,
> because you need to
> be root to update the locate database. As a result,
> the buffer does
> not get reverted.
>
> If you answer no, the *Locate* buffer does not get
> reverted either,
> whereas you might just have wanted to revert to undo
> manual changes
> to the buffer and whereas the locate database might
> have been updated
> by cron, or by the user, in the meantime anyway.
>
> A few days ago, I got a request to make this
> behavior customizable,
> which was CC-ed to emacs-pretesters instead of the
> more appropriate
> emacs-devel.
>
> The patch below introduces an option allowing the
> user to avoid the
> question. The default remains to ask the question.
> But, even for the
> default behavior there is a change: if the user
> answers no, the buffer
> gets reverted without updating the database.
>
> If there are no objections, I will install the patch
> below:
>
> ===File
> ~/locate-diff=======================================
> *** locate.el 15 Mar 2006 19:31:47 -0600 1.36
> --- locate.el 25 Jun 2006 20:49:16 -0500
> ***************
> *** 191,196 ****
> --- 191,204 ----
> :group 'locate
> :version "22.1")
>
> + (defcustom locate-update-when-revert t
> + "This option affects how the *Locate* buffer
> gets reverted.
> + If non-nil, offer to update the locate database
> when reverting that buffer.
> + If nil, reverting does not update the locate
> database."
> + :type 'boolean
> + :group 'locate
> + :version "22.1")
> +
> (defcustom locate-update-command "updatedb"
> "The executable program used to update the
> locate database."
> :type 'string
> ***************
> *** 557,568 ****
>
> ;; From Stephen Eglen <stephen@cns.ed.ac.uk>
> (defun locate-update (ignore1 ignore2)
> ! "Update the locate database.
> ! Database is updated using the shell command in
> `locate-update-command'."
> (let ((str (car locate-history-list)))
> ! (cond ((yes-or-no-p "Update locate database
> (may take a few seconds)? ")
> ! (shell-command locate-update-command)
> ! (locate str)))))
>
> ;;; Modified three functions from `dired.el':
> ;;; dired-find-directory,
> --- 565,578 ----
>
> ;; From Stephen Eglen <stephen@cns.ed.ac.uk>
> (defun locate-update (ignore1 ignore2)
> ! "Revert the *Locate* buffer.
> ! If `locate-update-when-revert' is non-nil, offer
> to update the
> ! locate database using the shell command in
> `locate-update-command'."
> (let ((str (car locate-history-list)))
> ! (and locate-update-when-revert
> ! (yes-or-no-p "Update locate database (may take a
> few seconds)? ")
> ! (shell-command locate-update-command))
> ! (locate str)))
>
> ;;; Modified three functions from `dired.el':
> ;;; dired-find-directory,
>
============================================================
>
>
next prev parent reply other threads:[~2006-06-26 13:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 3:27 Reverting *Locate* buffers Luc Teirlinck
2006-06-26 7:43 ` David Kastrup
2006-06-28 1:58 ` Luc Teirlinck
2006-06-28 3:55 ` T. V. Raman
2006-06-29 3:13 ` Luc Teirlinck
2006-06-29 6:27 ` David Kastrup
2006-06-29 21:52 ` Michael Albinus
2006-06-30 1:55 ` Luc Teirlinck
2006-07-02 20:39 ` Michael Albinus
2006-07-02 20:52 ` Michael Albinus
2006-07-03 2:51 ` Luc Teirlinck
2006-07-03 13:43 ` Michael Albinus
2006-07-03 23:21 ` Richard Stallman
2006-07-04 0:14 ` Luc Teirlinck
2006-07-03 15:05 ` Richard Stallman
2006-07-03 15:37 ` Michael Albinus
2006-07-03 15:41 ` David Kastrup
2006-07-04 15:42 ` Stefan Monnier
2006-06-29 21:58 ` Michael Albinus
2006-06-26 13:15 ` Peter Breton [this message]
2006-06-27 1:55 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626131546.93100.qmail@web55513.mail.re4.yahoo.com \
--to=peter_breton@yahoo.com \
--cc=emacs-pretesters@gnu.org \
--cc=pbreton@cs.umb.edu \
--cc=raman@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.