From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.devel Subject: Re: delete-process bug (was: Ispell loads dict twice.) Date: Thu, 25 May 2006 14:19:47 +0200 Message-ID: <20060525121947.GA4957@agmartin.aq.upm.es> References: <87k69eyddj.fsf@lrde.org> <87fyj0r41g.fsf@lrde.org> <20060524112846.GA12046@agmartin.aq.upm.es> <87bqtmjrsh.fsf_-_@lrde.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1148559794 11284 80.91.229.2 (25 May 2006 12:23:14 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 25 May 2006 12:23:14 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 25 14:23:12 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FjErr-0008Tc-La for ged-emacs-devel@m.gmane.org; Thu, 25 May 2006 14:23:07 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FjErr-0008PZ-3J for ged-emacs-devel@m.gmane.org; Thu, 25 May 2006 08:23:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FjEre-0008PM-8j for emacs-devel@gnu.org; Thu, 25 May 2006 08:22:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FjErb-0008P1-KT for emacs-devel@gnu.org; Thu, 25 May 2006 08:22:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FjErb-0008Ow-HV for emacs-devel@gnu.org; Thu, 25 May 2006 08:22:51 -0400 Original-Received: from [138.100.4.49] (helo=edison.ccupm.upm.es) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1FjEwG-0003Dm-F8 for emacs-devel@gnu.org; Thu, 25 May 2006 08:27:40 -0400 Original-Received: from mala.aq.upm.es (Agmartin.aq.upm.es [138.100.41.131]) by edison.ccupm.upm.es (8.13.6/8.13.6) with ESMTP id k4PCJl1C018671; Thu, 25 May 2006 14:19:47 +0200 Original-Received: by mala.aq.upm.es (Postfix, from userid 1000) id CA8DFE051; Thu, 25 May 2006 14:19:47 +0200 (CEST) Original-To: emacs-devel@gnu.org Mail-Followup-To: emacs-devel@gnu.org Content-Disposition: inline In-Reply-To: <87bqtmjrsh.fsf_-_@lrde.org> User-Agent: Mutt/1.5.11+cvs20060403 X-MIME-Autoconverted: from 8bit to quoted-printable by edison.ccupm.upm.es id k4PCJl1C018671 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:55265 Archived-At: On Thu, May 25, 2006 at 12:57:18PM +0200, Micha=EBl Cadilhac wrote:[B > Agustin Martin writes: >=20 > > Ispell process killed > > Starting new Ispell process [american] ... > > Error in post-command-hook: (error ispell exited with signal Killed) >=20 > This is not really due to my patch. However, it shows a real race > condition in process management of Emacs: Thanks for clarifying, I was also guessing so, your patch was working pretty well at home (Debian stable emacs21.4), but failed randomly at work in both Debian stable emacs21.4 (tested this morning) and in Debian unstable emacs21.4 and emacs-snapshot, in all cases even in a clean environment. The only difference left is that my home computer is slower than the one = I use at work. Besides the race condition, your ispell.el original patch seems very reasonable to me. It is a pity that upstream ispell.el mailing list is not archived anywher= e, and that we cannot browse its CVS logs, to check if original code was intended as a workaround for this kind of race conditions. > After an hour of debugging, I can propose a small change that fixes > this bug and lets no room for any other race condition of that kind, > AFAICT. I agree that is the race condition what needs to be fixed instead of usin= g strange workarounds. Thanks for your feedback, --=20 Agustin