From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: comint-insert-input on non-command lines: Date: Thu, 11 May 2006 17:40:47 -0500 (CDT) Message-ID: <200605112240.k4BMelnT018936@jane.dms.auburn.edu> References: <17501.373.791079.156322@rgrjr.dyndns.org> <17502.37204.411491.461843@farnswood.snap.net.nz> <200605080408.k4848t65027552@jane.dms.auburn.edu> <17502.50834.303952.808659@farnswood.snap.net.nz> <200605090301.k4931NbZ010512@jane.dms.auburn.edu> <17504.2770.189282.768887@farnswood.snap.net.nz> <200605090359.k493xjVi010576@jane.dms.auburn.edu> <17504.13295.579987.394734@farnswood.snap.net.nz> <200605091458.k49EwOL8012994@jane.dms.auburn.edu> <20060510010929.723AA627ED@farnswood.snap.net.nz> <200605100441.k4A4f636019170@jane.dms.auburn.edu> <17505.31314.844449.970281@farnswood.snap.net.nz> <200605100606.k4A661Rs019271@jane.dms.auburn.edu> <17506.23893.746029.146542@farnswood.snap.net.nz> <200605110133.k4B1XupP029271@jane.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1147387368 17286 80.91.229.2 (11 May 2006 22:42:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 11 May 2006 22:42:48 +0000 (UTC) Cc: nickrob@snap.net.nz, rogers-emacs@rgrjr.dyndns.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 12 00:42:45 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FeJra-0008Rp-E6 for ged-emacs-devel@m.gmane.org; Fri, 12 May 2006 00:42:30 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FeJrZ-00005e-Vt for ged-emacs-devel@m.gmane.org; Thu, 11 May 2006 18:42:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FeJr0-00084A-9b for emacs-devel@gnu.org; Thu, 11 May 2006 18:41:54 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FeJqy-00082W-J2 for emacs-devel@gnu.org; Thu, 11 May 2006 18:41:53 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FeJqy-00082G-7C for emacs-devel@gnu.org; Thu, 11 May 2006 18:41:52 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FeJsY-0007eX-Ox; Thu, 11 May 2006 18:43:30 -0400 Original-Received: from jane.dms.auburn.edu (jane.dms.auburn.edu [131.204.53.201]) by manatee.dms.auburn.edu (8.13.6/8.13.6) with ESMTP id k4BMfofR001043; Thu, 11 May 2006 17:41:50 -0500 (CDT) Original-Received: from jane.dms.auburn.edu (localhost [127.0.0.1]) by jane.dms.auburn.edu (8.13.4+Sun/8.13.4) with ESMTP id k4BMeli3018939; Thu, 11 May 2006 17:40:47 -0500 (CDT) Original-Received: (from teirllm@localhost) by jane.dms.auburn.edu (8.13.4+Sun/8.13.3/Submit) id k4BMelnT018936; Thu, 11 May 2006 17:40:47 -0500 (CDT) X-Authentication-Warning: jane.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Thu, 11 May 2006 14:31:35 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:54290 Archived-At: Richard Stallman wrote: I will update the docs as soon as I am sure that Richard does not object against reverting this change. This change shouldn't have been made now without discussion and my approval. Reverting it is the right thing to do. The change was made about two years ago with your approval, but it was presented as eliminating code duplication without any change in functionality. Actually, from this thread I have the impression that Nick was not even aware that his change involved a change in functionality. We discovered recently that there were several very non-trivial changes in functionality, as well as bugs. These changes were never discussed, as people were not aware of them. While Nick's changes are nearly two years old, they were never part of any release, so if we are going to revert them, then now is the time. First of all, the change broke `C-c RET' completely when comint-use-prompt-regexp is non-nil. Secondly, it introduced differences, in some derived modes substantial differences, between `C-c RET' and RET, whereas the only difference is supposed to be that `C-c RET' offers you a chance to edit the text that RET immediately executes. Some features of `C-c RET', which some people apparently relied on, were eliminated. The easiest way to deal with the above problems is to revert Nick's changes, which Nick already partly did. The work that remains to be done if we continue this way is to better document the behavior of `C-c RET', RET and mouse-2 in Comint buffers. Because if comint-use-prompt-regexp is non-nil there are no fields in the buffer, it is essentially impossible to implement something close to Nick's `C-c RET' behavior if that variable is non-nil. So the alternative to reverting Nicks change is: get rid of comint-use-prompt-regexp entirely, something I believe we are not ready to do, not now and maybe never; make RET behave like Nick's `C-c RET'; put the old `C-c RET' and RET functionality on some different keys, because people still want it (the old functionality is especially powerful in external Inferior Lisp buffers); document all that. The biggest and essentially irreversible decision in all this would be the elimination of comint-use-prompt-regexp. The amount of work would be big and the risk would be big, all supposedly shortly before a release. Sincerely, Luc.