From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dan Nicolaescu Newsgroups: gmane.emacs.devel Subject: query-replace in isearch (was Re: should search ring contain duplicates?) Date: Wed, 03 May 2006 08:04:08 -0700 Message-ID: <200605031504.k43F49hr001544@scanner2.ics.uci.edu> References: <200605030727.k437R2Wx009975@amrm2.ics.uci.edu> <87bqufwbls.fsf@jurta.org> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1146668800 18202 80.91.229.2 (3 May 2006 15:06:40 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 3 May 2006 15:06:40 +0000 (UTC) Cc: emacs-devel@gnu.org, "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 03 17:06:37 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FbIvE-0001f3-8p for ged-emacs-devel@m.gmane.org; Wed, 03 May 2006 17:05:48 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbIvD-0003ep-Qz for ged-emacs-devel@m.gmane.org; Wed, 03 May 2006 11:05:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FbIuU-0003LH-14 for emacs-devel@gnu.org; Wed, 03 May 2006 11:05:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FbIuT-0003Kj-43 for emacs-devel@gnu.org; Wed, 03 May 2006 11:05:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FbIuS-0003Kb-Ua for emacs-devel@gnu.org; Wed, 03 May 2006 11:05:00 -0400 Original-Received: from [128.195.1.36] (helo=scanner2.ics.uci.edu) by monty-python.gnu.org with esmtp (Exim 4.52) id 1FbIur-0006vx-Hp for emacs-devel@gnu.org; Wed, 03 May 2006 11:05:25 -0400 Original-Received: from vino.ics.uci.edu (vino.ics.uci.edu [128.195.11.198]) by scanner2.ics.uci.edu (8.13.6/8.13.5) with ESMTP id k43F49hr001544; Wed, 3 May 2006 08:04:09 -0700 (PDT) Original-To: Juri Linkov In-Reply-To: <87bqufwbls.fsf@jurta.org> (Juri Linkov's message of "Wed, 03 May 2006 15:48:48 +0300") Original-Lines: 14 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam (whitelisted), SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@vino.ics.uci.edu X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:53854 Archived-At: [snip] > I think this is a good idea. This would help to get rid of a new > useless argument `keep-all' added a few months ago to the function > `read-from-minibuffer' only for the sake of query-replace. > Since query-replace is the only place in Emacs that uses this new argument, > it is better to remove it now before the release, and to use a new > macro `history-push' in `query-replace-read-to' to treat the query-replace > history specially. This reminds me of the fact that doing `query-replace' from isearch does not put `query-replace' in the complex command history. IMHO it should. i.e.: C-s FOO M-% BAR RET C-x ESC ESC should show the same thing as M-% FOO RET BAR RET C-x ESC ESC