Re: Ispell loads dict twice.

[Agustin Martin <agustin.martin@hispalinux.es>]

[-- Attachment #1: Type: text/plain, Size: 1021 bytes --]

On Mon, Apr 24, 2006 at 09:36:40PM +0200, Michaël Cadilhac wrote:
> $ emacs -Q
> 
> C-u M-x ispell-change-dictionary RET francais RET
> C-x b test1 RET
> M-x ispell-change-dictionary RET english RET
> M-x ispell-buffer
> C-x b test2 RET
> M-x ispell-change-dictionary RET english RET
> 
>   The « english » dictionary will be loaded twice: on the
>   « ispell-buffer » and on the latest « ispell-change-dictionary ».

While the above problem looks rather minor your patch seems to work
well here, both the above and the personal dict part. I would only
suggest a very minor cosmetic change, as in attached patch (to be
applied on top of your patch), just to help people reading the code
to understand how that call works without looking at 
`ispell-buffer-local-dict' definition.

If this is used along with your patch, no specific changelog entry is
needed, otherwise something like

(ispell-change-dictionary)
 Make (ispell-buffer-local-dict) call more verbose

might suffice

-- 
Agustin

[-- Attachment #2: ispell.el.double_call+pdict+changes.diff --]
[-- Type: text/plain, Size: 459 bytes --]

--- ispell.el.0	2006-04-25 12:20:28.000000000 +0200
+++ ispell.el	2006-04-25 12:29:49.000000000 +0200
@@ -2577,7 +2577,7 @@
 	       (mapcar 'list (ispell-valid-dictionary-list)))
 	  nil t)
 	 current-prefix-arg))
-  (unless arg (ispell-buffer-local-dict t))
+  (unless arg (ispell-buffer-local-dict 'no-reload))
   (if (equal dict "default") (setq dict nil))
   ;; This relies on completing-read's bug of returning "" for no match
   (cond ((equal dict "")

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel