From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: locate-with-filter Date: Mon, 20 Mar 2006 19:13:05 -0600 (CST) Message-ID: <200603210113.k2L1D5604292@raven.dms.auburn.edu> References: <200603160048.k2G0msu23696@raven.dms.auburn.edu> <200603170221.k2H2L1H14401@raven.dms.auburn.edu> <17435.52238.927514.585806@kahikatea.snap.net.nz> <200603181716.k2IHGpN17847@raven.dms.auburn.edu> <17436.56026.490667.58771@kahikatea.snap.net.nz> <200603190455.k2J4tEK25830@raven.dms.auburn.edu> <200603200512.k2K5CFN12390@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1142903944 9024 80.91.229.2 (21 Mar 2006 01:19:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 21 Mar 2006 01:19:04 +0000 (UTC) Cc: nickrob@snap.net.nz, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 21 02:19:02 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1FLVWW-0003l6-Ty for ged-emacs-devel@m.gmane.org; Tue, 21 Mar 2006 02:19:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLVWZ-0002NM-3P for ged-emacs-devel@m.gmane.org; Mon, 20 Mar 2006 20:19:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1FLVWO-0002N6-Qo for emacs-devel@gnu.org; Mon, 20 Mar 2006 20:18:52 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1FLVWM-0002Mt-S3 for emacs-devel@gnu.org; Mon, 20 Mar 2006 20:18:52 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1FLVWM-0002Mq-O7 for emacs-devel@gnu.org; Mon, 20 Mar 2006 20:18:50 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA:24) (Exim 4.52) id 1FLVWJ-0000Ld-2M; Mon, 20 Mar 2006 20:18:47 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.13.4+Sun/8.13.3) with ESMTP id k2L1IcUv014399; Mon, 20 Mar 2006 19:18:38 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id k2L1D5604292; Mon, 20 Mar 2006 19:13:05 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rms@gnu.org In-reply-to: (message from Richard Stallman on Mon, 20 Mar 2006 20:02:02 -0500) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.1 (manatee.dms.auburn.edu [131.204.53.104]); Mon, 20 Mar 2006 19:18:38 -0600 (CST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:51922 Archived-At: Richard Stallman wrote: How about making them use help-follow-symbol instead of help-follow? Wouldn't that make them work right? mouse-2 and RET _are_ working right in these buffers. That is not the problem. The problem is that the introductory text says to use `M-x help-follow', whereas it should be saying to use RET. The problem is that the "\\[help-follow]" in the docs is not working right, probably because of the use of `minor-mode-overriding-map-alist'. That is why I suggested to simply hardcode RET in the docstring and that is what my two last patches do. I do not understand this proposal at all. help-follow now does exactly the right thing for help buffers: it has a useful doc string but it always gets an error. I don't see why we should change that. If some other mode wants a different command, make a different command for it. I was not concerned with some other mode wanting a different command. I was concerned with a user wanting to bind help-follow to a different key than RET. With the current code, this will not work. After my latest patch to help-mode.el it would work. But maybe this is not important enough to worry about. Anyway, if the user quite simply can not rebind help-follow to anything but RET, then there definitely would be no problem with hardcoding RET in the two docs I was talking about. Sincerely, Luc.