Spell-Check Message menu item

Spell-Check Message menu item

[David Reitter]

The "Spell-Check Message" menu item is enabled all the time - even  
when no message is being edited. Adding a :enabled or :visible here  
would improve usability.

from ispell.el:

       (define-key ispell-menu-map [ispell-message]
	'(menu-item "Spell-Check Message" ispell-message
		    :help "Skip headers and included message text"))


Also, the whole menu is always visible - even when no frame is  
visible at all. Don't forget that menu bars can exist outside of  
frames. 

Re: Spell-Check Message menu item

[Agustin Martin]

[-- Attachment #1: Type: text/plain, Size: 709 bytes --]

On Mon, Feb 27, 2006 at 02:01:50PM +0000, David Reitter wrote:
> The "Spell-Check Message" menu item is enabled all the time - even  
> when no message is being edited. Adding a :enabled or :visible here  
> would improve usability.
> 
> from ispell.el:
> 
>       (define-key ispell-menu-map [ispell-message]
> 	'(menu-item "Spell-Check Message" ispell-message
> 		    :help "Skip headers and included message text"))

Somethink like attached patch seems to work.

> Also, the whole menu is always visible - even when no frame is  
> visible at all. Don't forget that menu bars can exist outside of  
> frames. 

I am not an expert on this, how this can be done? With an example I might
try it.

-- 
Agustin

[-- Attachment #2: ispell.el_hide-spellcheck-message.diff --]
[-- Type: text/plain, Size: 480 bytes --]

--- ispell.el.orig	2006-03-08 10:53:00.000000000 +0100
+++ ispell.el	2006-03-08 15:53:42.000000000 +0100
@@ -1090,6 +1090,7 @@
 		    :help "Spell-check text in marked region"))
       (define-key ispell-menu-map [ispell-message]
 	'(menu-item "Spell-Check Message" ispell-message
+		    :visible (eq major-mode 'mail-mode)
 		    :help "Skip headers and included message text"))
       (define-key ispell-menu-map [ispell-buffer]
 	'(menu-item "Spell-Check Buffer" ispell-buffer

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel