From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: Bug, probably related to Custom Themes. Date: Fri, 23 Dec 2005 13:38:00 -0600 (CST) Message-ID: <200512231938.jBNJc0G27918@raven.dms.auburn.edu> References: <200512210254.jBL2sj814876@raven.dms.auburn.edu> <87mziuqp2x.fsf@stupidchicken.com> <200512211840.jBLIefx25655@raven.dms.auburn.edu> <87vexiw3w4.fsf@stupidchicken.com> <200512212258.jBLMwt329838@raven.dms.auburn.edu> <200512230426.jBN4QQD18470@raven.dms.auburn.edu> NNTP-Posting-Host: main.gmane.org X-Trace: sea.gmane.org 1135366925 10906 80.91.229.2 (23 Dec 2005 19:42:05 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 23 Dec 2005 19:42:05 +0000 (UTC) Cc: cyd@stupidchicken.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Dec 23 20:42:03 2005 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Epsni-0002PA-F1 for ged-emacs-devel@m.gmane.org; Fri, 23 Dec 2005 20:42:02 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Epsom-0003gR-5z for ged-emacs-devel@m.gmane.org; Fri, 23 Dec 2005 14:43:08 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Epsoe-0003gM-8f for emacs-devel@gnu.org; Fri, 23 Dec 2005 14:43:00 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Epsod-0003g4-Ks for emacs-devel@gnu.org; Fri, 23 Dec 2005 14:42:59 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Epsod-0003fz-Dr for emacs-devel@gnu.org; Fri, 23 Dec 2005 14:42:59 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EpsmB-00038V-2u; Fri, 23 Dec 2005 14:40:27 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.13.3+Sun/8.13.3) with ESMTP id jBNJe0n3010969; Fri, 23 Dec 2005 13:40:00 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id jBNJc0G27918; Fri, 23 Dec 2005 13:38:00 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: rms@gnu.org In-reply-to: (rms@gnu.org) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.1 (manatee.dms.auburn.edu [131.204.53.104]); Fri, 23 Dec 2005 13:40:00 -0600 (CST) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:48263 Archived-At: Richard Stallman wrote: Please don't exaggerate the negative. Despite the existence of a few bugs such as this one, the custom themes code basically works. Its basic design is completely flawed, for the reasons I explained. Now we'll fix this bug, and it will work even better. Suppose the bug I reported would be fixed. That would not be the end of the trouble. After selecting "Erase Customization", the State button will still say "SAVED and set" (instead of the expected "STANDARD") and the "Erase Customization" part of the State Menu will still be active. (It should _not_ be, since it will have no further effect when selected again.) All of this is very confusing to the user. When a value is set by a theme, the State button should not say "SAVED and set" and the "Erase Customization" part of the State menu should not be enabled. Better than "SAVED and set" would be "STANDARD", still better "THEME value". Themes should set the standard-value property, not the saved-value one and they should set the Custom state to 'standard, or even better 'theme, not to 'saved. With the current Themes code, any attempt to fix bugs in the Themes code can badly mess up Custom for everybody, including people who do not use Themes at all. (It _did_ happen in the case of the bug I reported.) This should not happen. The Themes code should be in a separate file, which is not even loaded if you do not use themes. It should not be intertwined with Custom as it is now. Sincerely, Luc.