a couple of bugs in bash indentation

a couple of bugs in bash indentation

[Nicholas Sushkin]

[-- Attachment #1: Type: text/plain, Size: 347 bytes --]

Stefan,

I think I found a couple of bugs in the indentation. Is your code also 
responsible for the indentation in bash-mode?

The first bug occurs in a case statement with a multiline pattern. The 
second bug occurs in a multiline quoted string. See the attached test 
cases.

Thanks!
-- 
Nicholas Sushkin, Senior Software Engineer
Open Finance

[-- Attachment #2: bash-case-stmt-indentation.sh --]
[-- Type: application/x-shellscript, Size: 279 bytes --]

[-- Attachment #3: bash-multiline-argument-indentation.sh --]
[-- Type: application/x-shellscript, Size: 277 bytes --]

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: a couple of bugs in bash indentation

[Stefan Monnier]

> I think I found a couple of bugs in the indentation.  Is your code also 
> responsible for the indentation in bash-mode?

Not really, but it does influence it.  E.g. it was the cause of the first
bug in mentioned.  I believe I've now fixed it.

> function multiline-quote
> {
>     echo \
>         --arg1 "correct" \
>         --arg2 "correct" \
>         --multiline "correct 
> maybe correct" \
>     --aftermultiline "not correct" \
>     --allothers "skewed"
> }

This one is still up for grabs.  I don't have time to look at it.


        Stefan

Re: a couple of bugs in bash indentation

[Richard M. Stallman]

    > function multiline-quote
    > {
    >     echo \
    >         --arg1 "correct" \
    >         --arg2 "correct" \
    >         --multiline "correct 
    > maybe correct" \
    >     --aftermultiline "not correct" \
    >     --allothers "skewed"
    > }

Does anyone want to fix that indentation bug?

Re: a couple of bugs in bash indentation

[Michael Cadilhac]

Nicholas Sushkin <nsushkin@openfinance.com> writes:

> [... bugs ...]

  I was looking at that when I found that (It could have been fixed
  recently, I don't have updated for a week)

echo '\'
echo 'Hoho !'

  completely screws the thing. \' doesn't escape the ' in shell AFAIK.

-- 
    Michael Cadilhac, a.k.a. Micha [mika] |
                    Epita/LRDE promo 2007 |   )\._.,--....,'``.
123 av. de Fontainebleau | 08.70.65.13.14 |  /.  _.. \   _\  (` ._,.
94270 Le Kremlin Bicetre | 06.23.20.31.30 | '._.-(,_..'--(,_...`-..'

Re: a couple of bugs in bash indentation

[Stefan Monnier]

>   I was looking at that when I found that (It could have been fixed
>   recently, I don't have updated for a week)

> echo '\'
> echo 'Hoho !'

>   completely screws the thing. \' doesn't escape the ' in shell AFAIK.

Does the patch below help?


        Stefan


--- sh-script.el	21 nov 2005 23:21:26 -0500	1.172
+++ sh-script.el	22 nov 2005 14:15:10 -0500	
@@ -1002,6 +1002,8 @@
   ;; The list of special chars is taken from the single-unix spec
   ;; of the shell command language (under `quoting') but with `$' removed.
   `(("[^|&;<>()`\\\"' \t\n]\\(#+\\)" 1 ,sh-st-symbol)
+    ;; In a '...' the backslash is not escaping.
+    ("\\(\\\\\\)'" 1 ,sh-st-punc)
     ;; Make sure $@ and @? are correctly recognized as sexps.
     ("\\$\\([?@]\\)" 1 ,sh-st-symbol)
     ;; Find HEREDOC starters and add a corresponding rule for the ender.

Re: a couple of bugs in bash indentation

[Michael Cadilhac]

[-- Attachment #1.1: Type: text/plain, Size: 599 bytes --]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>>   I was looking at that when I found that (It could have been fixed
>>   recently, I don't have updated for a week)
>
>> echo '\'
>> echo 'Hoho !'
>
>>   completely screws the thing. \' doesn't escape the ' in shell AFAIK.
>
> Does the patch below help?

   Sure it does :-)

-- 
    Michael Cadilhac, a.k.a. Micha [mika] |
                    Epita/LRDE promo 2007 |   )\._.,--....,'``.
123 av. de Fontainebleau | 08.70.65.13.14 |  /.  _.. \   _\  (` ._,.
94270 Le Kremlin Bicetre | 06.23.20.31.30 | '._.-(,_..'--(,_...`-..'

[-- Attachment #1.2: Type: application/pgp-signature, Size: 188 bytes --]

[-- Attachment #2: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel