From: Dan Nicolaescu <dann@ics.uci.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Global Font Lock by default
Date: Mon, 31 Oct 2005 14:07:06 -0800 [thread overview]
Message-ID: <200510312207.j9VM79KN011654@scanner2.ics.uci.edu> (raw)
In-Reply-To: <87ll09pd8v.fsf@pacem.orebokech.com> (Romain Francoise's message of "Mon, 31 Oct 2005 22:50:40 +0100")
Romain Francoise <romain@orebokech.com> writes:
> Dan Nicolaescu <dann@ics.uci.edu> writes:
>
> > It seems that the difference is the fact that on 8 color ttys the face
> > does not specify any properties.
>
> Yes, but the reason why that makes a difference only when font-lock.el
> is loaded in a dumped Emacs escapes me...
When dumping this part of the font-lock-comment-face face specification matches:
(t (:weight bold :slant italic)) so the face is created with bold and
italic properties.
later at run time face-spec-choose is called this will match:
"((class color) (min-colors 8) (background light))"
but because it specifies no properties face-spec-set returns
nil => face-spec-reset-face is not called in face-spec-set => the bold
and italic attributes are kept...
Is this a corner case that was not exercised until now? Or is this by
design?
In case this is by design, then a better "fix" would be this:
*** font-lock.el 31 Oct 2005 08:29:09 -0800 1.280
--- font-lock.el 31 Oct 2005 14:06:07 -0800
***************
*** 1691,1699 ****
(((class color) (min-colors 16) (background dark))
(:foreground "red1"))
(((class color) (min-colors 8) (background light))
! )
(((class color) (min-colors 8) (background dark))
! )
(t (:weight bold :slant italic)))
"Font Lock mode face used to highlight comments."
:group 'font-lock-highlighting-faces)
--- 1691,1699 ----
(((class color) (min-colors 16) (background dark))
(:foreground "red1"))
(((class color) (min-colors 8) (background light))
! (:inherit default))
(((class color) (min-colors 8) (background dark))
! (:inherit default))
(t (:weight bold :slant italic)))
"Font Lock mode face used to highlight comments."
:group 'font-lock-highlighting-faces)
next prev parent reply other threads:[~2005-10-31 22:07 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 20:34 Global Font Lock by default Richard M. Stallman
2005-10-29 21:51 ` Kim F. Storm
2005-10-29 23:44 ` David Kastrup
2007-02-27 19:59 ` Stuart D. Herring
2005-10-30 14:52 ` Richard M. Stallman
2005-10-31 16:48 ` Dan Nicolaescu
2005-10-31 17:31 ` Romain Francoise
2005-10-31 17:47 ` Dan Nicolaescu
2005-10-31 18:35 ` Romain Francoise
2005-10-31 20:48 ` Dan Nicolaescu
2005-10-31 21:11 ` Romain Francoise
2005-10-31 21:24 ` Dan Nicolaescu
2005-10-31 21:50 ` Romain Francoise
2005-10-31 22:07 ` Dan Nicolaescu [this message]
2005-10-31 22:21 ` Stefan Monnier
2005-10-31 22:41 ` Dan Nicolaescu
2005-10-31 22:52 ` Stefan Monnier
2005-10-31 23:20 ` Miles Bader
2005-11-01 15:05 ` Dan Nicolaescu
2005-11-01 11:56 ` Romain Francoise
2005-11-01 21:52 ` Richard M. Stallman
2005-11-02 22:51 ` Dan Nicolaescu
2005-11-01 4:53 ` Eli Zaretskii
2005-11-01 6:25 ` Dan Nicolaescu
2005-11-01 6:35 ` Dan Nicolaescu
2005-11-01 19:50 ` Eli Zaretskii
2005-11-01 20:43 ` Dan Nicolaescu
2005-11-02 4:23 ` Eli Zaretskii
2005-11-02 5:46 ` Dan Nicolaescu
2005-11-02 18:55 ` Eli Zaretskii
2005-11-02 20:00 ` Dan Nicolaescu
2005-11-03 4:39 ` Eli Zaretskii
2005-11-03 5:53 ` Dan Nicolaescu
2005-11-04 11:01 ` Eli Zaretskii
2005-11-04 14:20 ` Eli Zaretskii
2005-11-06 19:47 ` Dan Nicolaescu
2005-11-01 7:29 ` Dan Nicolaescu
2005-11-01 10:03 ` Kim F. Storm
2005-11-01 12:04 ` Kim F. Storm
2005-11-01 12:56 ` Chong Yidong
2005-11-01 13:36 ` Kim F. Storm
2005-11-01 15:10 ` Dan Nicolaescu
2005-11-01 17:19 ` Luc Teirlinck
2005-11-01 17:23 ` Luc Teirlinck
2005-11-01 17:28 ` Luc Teirlinck
2005-11-01 19:57 ` Eli Zaretskii
2005-11-01 19:54 ` Eli Zaretskii
2005-11-01 20:03 ` Kim F. Storm
2005-11-02 1:33 ` Luc Teirlinck
2005-11-02 10:27 ` Richard M. Stallman
2005-11-02 12:08 ` David Kastrup
2005-11-02 14:10 ` Luc Teirlinck
2005-11-03 13:50 ` Richard M. Stallman
2005-11-03 14:57 ` Stefan Monnier
2005-11-03 16:24 ` David Kastrup
2005-11-04 2:03 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510312207.j9VM79KN011654@scanner2.ics.uci.edu \
--to=dann@ics.uci.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.