recenter is broken

recenter is broken

[Luc Teirlinck]

The following change:

2005-07-06  Richard M. Stallman  <rms@gnu.org>

	    * window.c (Frecenter): When arg is inside the scroll
              margin, move it out of the margin.

has some very annoying consequences.

Do `emacs -q -nbc' then:

C-h n
M-x end-of-buffer

Note how the entire file is completely overscrolled out of view.
Apparently, the `(recenter -3)' at the end of end-of-buffer no longer
works.

Sincerely,

Luc.

Re: recenter is broken

[Richard M. Stallman]

    Do `emacs -q -nbc' then:

    C-h n
    M-x end-of-buffer

    Note how the entire file is completely overscrolled out of view.

Does this give good results?

*** window.c	06 Jul 2005 14:54:17 -0400	1.509
--- window.c	07 Jul 2005 16:02:47 -0400	
***************
*** 5372,5377 ****
--- 5372,5379 ----
       line counts would lead to strange effects.  */
    if (FRAME_WINDOW_P (XFRAME (w->frame)))
      {
+       iarg = XINT (arg);
+ 
        if (center_p)
  	{
  	  struct it it;
***************
*** 5391,5397 ****
  	  int extra_line_spacing;
  	  int h = window_box_height (w);
  
- 	  iarg = XINT (arg);
  	  iarg = - max (-iarg, this_scroll_margin);
  
  	  SET_TEXT_POS (pt, PT, PT_BYTE);
--- 5393,5398 ----
***************
*** 5453,5459 ****
  	{
  	  struct position pos;
  
- 	  iarg = XINT (arg);
  	  iarg = max (iarg, this_scroll_margin);
  
  	  pos = *vmotion (PT, -iarg, w);
--- 5454,5459 ----

Re: recenter is broken

[Luc Teirlinck]

Richard Stallman wrote:
       
       Do `emacs -q -nbc' then:

       C-h n
       M-x end-of-buffer

       Note how the entire file is completely overscrolled out of view.

   Does this give good results?

I believe that Kim already fixed this some other way, because recenter
appears to work fine in the latest CVS.

Sincerely,

Luc.