dired and arc-mode don't bind C-/ to undo (w/ patch)

dired and arc-mode don't bind C-/ to undo (w/ patch)

[John Hawkinson]

This bug report will be sent to the Free Software Foundation,
not to your local site managers!
Please write in English, because the Emacs maintainers do not have
translators to read other languages for them.

Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list,
and to the gnu.emacs.bug news group.

In GNU Emacs 21.3.1 (sparc-sun-solaris2.9, X toolkit)
 of 2004-10-27 on downy.mit.edu
configured using `configure  --with-x-toolkit --sharedstatedir=/var/tmp --with-pop --with-hesiod --with-kerberos'
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

    I tried to undo an accidental typo ("k") in dired mode,
and discovered that while C-x u and C-_ are bound to dired-undo,
C-/ is not. This is awful confusing since for many users,
C-/ is the most-remembered undo binding, because it is easy
to type.

    arc-mode appears to have the same problem. Here's a patch
to rebind C-/ locally in dired and arc-mode. I think the 
current behavior is confusing and undesirable, and I do not
think anyone is depending on it.

Thanks.

--jhawk@mit.edu
  John Hawkinson

diff -ur ./arc-mode.el /tmp/emacs/arc-mode.el
--- ./arc-mode.el	Wed Oct 27 00:29:24 2004
+++ /tmp/emacs/arc-mode.el	Mon Jan 24 20:53:38 2005
@@ -605,7 +605,8 @@
       (progn
 	;; Not a nice "solution" but it'll have to do
 	(define-key archive-mode-map "\C-xu" 'archive-undo)
-	(define-key archive-mode-map "\C-_" 'archive-undo))
+	(define-key archive-mode-map "\C-_" 'archive-undo)
+	(define-key archive-mode-map [?\C-/] 'archive-undo))
     (substitute-key-definition 'undo 'archive-undo
 			       archive-mode-map global-map))
 
diff -ur ./dired.el /tmp/emacs/dired.el
--- ./dired.el	Wed Oct 27 00:29:24 2004
+++ /tmp/emacs/dired.el	Mon Jan 24 20:54:01 2005
@@ -979,6 +979,7 @@
     (define-key map "\177" 'dired-unmark-backward)
     (define-key map "\C-_" 'dired-undo)
     (define-key map "\C-xu" 'dired-undo)
+    (define-key map [?\C-/] 'dired-undo)
 
     ;; Make menu bar items.

Re: dired and arc-mode don't bind C-/ to undo (w/ patch)

[Richard Stallman]

I will fix this using command remapping.
Do you know of any other modes that need similar changes?

Re: dired and arc-mode don't bind C-/ to undo (w/ patch)

[John Hawkinson]

Richard Stallman <rms@gnu.org> wrote on Tue, 25 Jan 2005
at 19:03:48 -0500 in <E1Ctaey-0002oP-Tr@fencepost.gnu.org>:

> I will fix this using command remapping.

That sounds like it might be a more general solution, thanks.

> Do you know of any other modes that need similar changes?

Those are the only two that I know of. I only encountered dired, and
looked around and then found arc-mode as well. It is possible that
there are other cases that don't use (define-key), but I think those
are the only two cases that do.

Thanks.

--jhawk