From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: John Hawkinson Newsgroups: gmane.emacs.bugs Subject: dired and arc-mode don't bind C-/ to undo (w/ patch) Date: Mon, 24 Jan 2005 20:58:41 -0500 (EST) Message-ID: <200501250158.j0P1wf7c005537@mint-square.mit.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1106619523 2413 80.91.229.6 (25 Jan 2005 02:18:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 25 Jan 2005 02:18:43 +0000 (UTC) Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Jan 25 03:18:37 2005 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CtGHs-0001gL-00 for ; Tue, 25 Jan 2005 03:18:37 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CtGU7-0000Vp-Dh for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jan 2005 21:31:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1CtGTF-0000De-D4 for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2005 21:30:23 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1CtGTB-00009U-SV for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2005 21:30:17 -0500 Original-Received: from [18.7.7.80] (helo=biscayne-one-station.mit.edu) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.34) id 1CtFye-0001jx-RY for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2005 20:58:44 -0500 Original-Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103]) by biscayne-one-station.mit.edu (8.12.4/8.9.2) with ESMTP id j0P1whD1016950; Mon, 24 Jan 2005 20:58:43 -0500 (EST) Original-Received: from mint-square.mit.edu (MINT-SQUARE.MIT.EDU [18.7.16.77]) (authenticated bits=56) (User authenticated as jhawk@ATHENA.MIT.EDU) by outgoing.mit.edu (8.12.4/8.12.4) with ESMTP id j0P1wfsS010160 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 24 Jan 2005 20:58:42 -0500 (EST) Original-Received: (from jhawk@localhost) by mint-square.mit.edu (8.12.9) id j0P1wf7c005537; Mon, 24 Jan 2005 20:58:41 -0500 (EST) Original-To: bug-gnu-emacs@gnu.org X-Scanned-By: MIMEDefang 2.42 X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:10562 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:10562 This bug report will be sent to the Free Software Foundation, not to your local site managers! Please write in English, because the Emacs maintainers do not have translators to read other languages for them. Your bug report will be posted to the bug-gnu-emacs@gnu.org mailing list, and to the gnu.emacs.bug news group. In GNU Emacs 21.3.1 (sparc-sun-solaris2.9, X toolkit) of 2004-10-27 on downy.mit.edu configured using `configure --with-x-toolkit --sharedstatedir=/var/tmp --with-pop --with-hesiod --with-kerberos' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil locale-coding-system: nil default-enable-multibyte-characters: t Please describe exactly what actions triggered the bug and the precise symptoms of the bug: I tried to undo an accidental typo ("k") in dired mode, and discovered that while C-x u and C-_ are bound to dired-undo, C-/ is not. This is awful confusing since for many users, C-/ is the most-remembered undo binding, because it is easy to type. arc-mode appears to have the same problem. Here's a patch to rebind C-/ locally in dired and arc-mode. I think the current behavior is confusing and undesirable, and I do not think anyone is depending on it. Thanks. --jhawk@mit.edu John Hawkinson diff -ur ./arc-mode.el /tmp/emacs/arc-mode.el --- ./arc-mode.el Wed Oct 27 00:29:24 2004 +++ /tmp/emacs/arc-mode.el Mon Jan 24 20:53:38 2005 @@ -605,7 +605,8 @@ (progn ;; Not a nice "solution" but it'll have to do (define-key archive-mode-map "\C-xu" 'archive-undo) - (define-key archive-mode-map "\C-_" 'archive-undo)) + (define-key archive-mode-map "\C-_" 'archive-undo) + (define-key archive-mode-map [?\C-/] 'archive-undo)) (substitute-key-definition 'undo 'archive-undo archive-mode-map global-map)) diff -ur ./dired.el /tmp/emacs/dired.el --- ./dired.el Wed Oct 27 00:29:24 2004 +++ /tmp/emacs/dired.el Mon Jan 24 20:54:01 2005 @@ -979,6 +979,7 @@ (define-key map "\177" 'dired-unmark-backward) (define-key map "\C-_" 'dired-undo) (define-key map "\C-xu" 'dired-undo) + (define-key map [?\C-/] 'dired-undo) ;; Make menu bar items.