From: Andries Brouwer <Andries.Brouwer@cwi.nl>
Cc: bug-cc-mode@gnu.org, acm@muc.de,
Andries Brouwer <Andries.Brouwer@cwi.nl>,
monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: cc-mode adds newlines
Date: Sun, 2 Jan 2005 19:02:20 +0100 [thread overview]
Message-ID: <20050102180220.GE7647@apps.cwi.nl> (raw)
In-Reply-To: <E1Cl8Eu-0007Bx-TD@fencepost.gnu.org>
On Sun, Jan 02, 2005 at 11:05:56AM -0500, Richard Stallman wrote:
A happy 2005 to you!
> Maybe I would be tempted to invent a prepare-write-file-hook
> (if there is none already) that would do any required transformations
> before the file is actually written.
>
> Both save-buffer and write-file could call this hook.
>
> This hook could set file-changed in case it adds a final newline.
>
> Now if save-buffer only tests file-changed after calling
> prepare-write-file-hook it notices the change.
>
> Actually, save-buffer doesn't add a newline, or do much of anything,
> unless the buffer is already marked "modified". The present problem,
> or at least you've considered it one, is that write-file adds the
> newline unconditionally. That is because write-file marks the buffer
> modified before it calls save-buffer.
>
> I don't think your proposal would alter what happens in this case.
I was of the opinion that write-file and save-buffer should show
consistent behaviour; if write-file changes the contents of a file
by adding an additional byte, even when so far the file was not
modified, then save-buffer should also do that - this consistency
is what is obtained by the above suggestion.
Of course I consider silently changing a user's files to be
something terrible, so this prepare-write-file-hook should
do this adding of a newline only when there is some very explicit
evidence that this is what the user wants, like a setting in .emacs.
Certainly the chosen filename alone should not suffice.
Andries
next prev parent reply other threads:[~2005-01-02 18:02 UTC|newest]
Thread overview: 111+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-28 16:56 cc-mode adds newlines Andries.Brouwer
[not found] ` <Andries.Brouwer@cwi.nl>
2004-11-28 17:17 ` Martin Stjernholm
2004-11-28 20:20 ` Andries Brouwer
2004-11-29 0:14 ` Kim F. Storm
2004-11-30 7:01 ` Richard Stallman
2004-12-31 15:26 ` Richard Stallman
2004-12-31 16:56 ` Andries Brouwer
2005-01-02 16:05 ` Richard Stallman
2005-01-02 18:02 ` Andries Brouwer [this message]
2004-11-30 7:01 ` Richard Stallman
2004-11-30 8:11 ` David Kastrup
2004-12-01 2:56 ` Richard Stallman
[not found] <mailman.3671.1100818498.8225.bug-gnu-emacs@gnu.org>
2004-11-18 23:23 ` Kevin Rodgers
2004-11-19 0:46 ` Andreas Schwab
2004-11-18 23:31 ` Jari Aalto
2004-11-18 23:31 ` Jari Aalto
2004-11-19 20:27 ` Alan Mackenzie
2004-11-19 23:13 ` Andries Brouwer
2004-11-20 0:13 ` Miles Bader
2004-11-20 15:14 ` Alan Mackenzie
2004-11-21 2:08 ` Andries Brouwer
2004-11-21 10:00 ` Miles Bader
2004-11-21 11:38 ` Andries Brouwer
2004-11-21 12:08 ` Alfred M. Szmidt
2004-11-21 12:45 ` Andries Brouwer
2004-11-21 12:58 ` Alfred M. Szmidt
2004-11-21 13:03 ` Andries Brouwer
2004-11-21 13:09 ` Alfred M. Szmidt
2004-11-22 0:03 ` Stefan Monnier
2004-11-21 12:53 ` Miles Bader
2004-11-21 13:00 ` Andries Brouwer
2004-11-21 13:14 ` David Kastrup
2004-11-21 13:35 ` Andries Brouwer
2004-11-21 13:41 ` David Kastrup
2004-11-21 13:54 ` Andries Brouwer
2004-11-21 15:54 ` Thien-Thi Nguyen
2004-11-21 11:06 ` David Kastrup
2004-11-21 11:45 ` Andries Brouwer
2004-11-21 12:08 ` David Kastrup
2004-11-21 11:41 ` Alan Mackenzie
2004-11-21 12:26 ` Andries Brouwer
2004-11-21 12:34 ` David Kastrup
2004-11-21 12:49 ` Andries Brouwer
2004-11-21 13:08 ` David Kastrup
2004-11-21 13:28 ` Andries Brouwer
2004-11-21 13:37 ` David Kastrup
2004-11-21 13:43 ` Andries Brouwer
2004-11-21 13:51 ` David Kastrup
2004-11-21 14:03 ` Andries Brouwer
2004-11-21 15:01 ` David Kastrup
2004-11-21 15:08 ` Andries Brouwer
2004-11-22 19:21 ` Kevin Rodgers
2004-11-21 15:18 ` Andreas Schwab
2004-11-21 15:36 ` Andries Brouwer
[not found] ` <01c4d003$Blat.v2.2.2$3d9a05c0@zahav.net.il>
2004-11-21 21:28 ` Andries Brouwer
2004-11-22 4:35 ` Eli Zaretskii
2004-11-22 9:04 ` David Kastrup
2004-11-21 13:52 ` Alan Mackenzie
2004-11-21 14:29 ` Andries Brouwer
2004-11-21 15:07 ` David Kastrup
2004-11-21 15:20 ` Andries Brouwer
2004-11-21 19:03 ` Alfred M. Szmidt
2004-11-21 21:19 ` Andries Brouwer
2004-11-21 21:46 ` Alfred M. Szmidt
2004-11-21 22:19 ` Andries Brouwer
2004-11-22 11:54 ` Benjamin Riefenstahl
2004-11-22 15:54 ` Andries Brouwer
2004-11-22 16:56 ` Andreas Schwab
2004-11-21 15:50 ` Kai Grossjohann
2004-11-22 19:20 ` Kevin Rodgers
2004-11-24 10:12 ` Kai Grossjohann
[not found] ` <01c4d002$Blat.v2.2.2$50b57dc0@zahav.net.il>
2004-11-21 21:21 ` Andries Brouwer
2004-11-22 4:31 ` Eli Zaretskii
2004-11-22 0:12 ` Stefan Monnier
2004-11-22 14:07 ` Richard Stallman
2004-11-22 15:52 ` Stefan Monnier
2004-11-22 19:16 ` Kevin Rodgers
2004-11-22 20:06 ` Stefan Monnier
2004-11-24 2:27 ` Richard Stallman
2004-11-24 4:27 ` Stefan Monnier
2004-11-28 14:45 ` Martin Stjernholm
2004-11-29 6:11 ` Richard Stallman
2004-11-30 10:51 ` Martin Stjernholm
2004-12-01 2:56 ` Richard Stallman
2004-11-21 14:47 ` Andreas Schwab
2004-11-21 15:03 ` Andries Brouwer
2004-11-21 15:39 ` Richard Stallman
2004-11-21 21:47 ` Alan Mackenzie
2004-11-23 16:30 ` Richard Stallman
2004-11-25 2:21 ` Richard Stallman
2004-11-25 20:35 ` Alan Mackenzie
[not found] ` <mailman.3684.1100821293.8225.bug-gnu-emacs@gnu.org>
2004-11-19 0:14 ` Stefan Monnier
2004-11-19 20:04 ` Richard Stallman
[not found] ` <mailman.56.1100895632.27204.bug-gnu-emacs@gnu.org>
2004-11-19 22:00 ` Hallvard B Furuseth
2004-11-21 15:38 ` Richard Stallman
[not found] ` <mailman.416.1101052189.27204.bug-gnu-emacs@gnu.org>
2004-11-22 5:55 ` Paul D. Smith
[not found] ` <mailman.619.1101127694.27204.bug-gnu-emacs@gnu.org>
2004-11-22 18:55 ` Stefan Monnier
[not found] ` <mailman.723.1101150150.27204.bug-gnu-emacs@gnu.org>
2004-11-22 19:37 ` Hallvard B Furuseth
2004-11-22 22:49 ` Andreas Schwab
[not found] ` <mailman.778.1101164414.27204.bug-gnu-emacs@gnu.org>
2004-11-28 19:39 ` Hallvard B Furuseth
-- strict thread matches above, loose matches on Subject: below --
2004-11-18 22:45 Andries.Brouwer
2003-01-24 5:18 Luc Teirlinck
2003-01-24 2:41 Luc Teirlinck
2003-01-24 1:36 Luc Teirlinck
2003-01-25 19:22 ` Richard Stallman
[not found] ` <mailman.985.1043522856.21513.bug-gnu-emacs@gnu.org>
2003-01-26 20:24 ` Benjamin Riefenstahl
[not found] <mailman.884.1043357104.21513.bug-gnu-emacs@gnu.org>
2003-01-23 23:35 ` Benjamin Riefenstahl
2003-01-23 22:41 Luc Teirlinck
2003-01-23 21:52 Luc Teirlinck
2003-01-23 21:25 Luc Teirlinck
2003-01-23 13:17 Rommerskirchen Heinrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050102180220.GE7647@apps.cwi.nl \
--to=andries.brouwer@cwi.nl \
--cc=acm@muc.de \
--cc=bug-cc-mode@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.