[patch] mode-line faces on 256-color terminals

[patch] mode-line faces on 256-color terminals

[Dan Nicolaescu]

The mode-line* faces were somehow missed when converting the face
definitions in faces.el to use min-colors, so that they work on
terminals that support 88 (or 256) colors.

This patch fixes the above issue. Is it OK? 

2004-12-22  Dan Nicolaescu  <dann@ics.uci.edu>

	* faces.el (mode-line, mode-line-inactive): Use min-colors.


Index: faces.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/faces.el,v
retrieving revision 1.296
diff -c -3 -p -c -r1.296 faces.el
*** faces.el	21 Dec 2004 11:37:25 -0000	1.296
--- faces.el	22 Dec 2004 23:02:48 -0000
*************** created."
*** 1783,1789 ****
  
  
  (defface mode-line
!   '((((type x w32 mac) (class color))
       :box (:line-width -1 :style released-button)
       :background "grey75" :foreground "black")
      (t
--- 1783,1789 ----
  
  
  (defface mode-line
!   '((((class color) (min-colors 88))
       :box (:line-width -1 :style released-button)
       :background "grey75" :foreground "black")
      (t
*************** created."
*** 1796,1806 ****
  (defface mode-line-inactive
    '((default
       :inherit mode-line)
!     (((type x w32 mac) (background light) (class color))
       :weight light
       :box (:line-width -1 :color "grey75" :style nil)
       :foreground "grey20" :background "grey90")
!     (((type x w32 mac) (background dark) (class color))
       :weight light
       :box (:line-width -1 :color "grey40" :style nil)
       :foreground "grey80" :background "grey30"))
--- 1796,1806 ----
  (defface mode-line-inactive
    '((default
       :inherit mode-line)
!     (((class color) (min-colors 88) (background light))
       :weight light
       :box (:line-width -1 :color "grey75" :style nil)
       :foreground "grey20" :background "grey90")
!     (((class color) (min-colors 88) (background dark) )
       :weight light
       :box (:line-width -1 :color "grey40" :style nil)
       :foreground "grey80" :background "grey30"))

Re: [patch] mode-line faces on 256-color terminals

[Eli Zaretskii]

> From: Dan Nicolaescu <dann@godzilla.ics.uci.edu>
> Date: Wed, 22 Dec 2004 15:08:50 -0800
> 
> The mode-line* faces were somehow missed when converting the face
> definitions in faces.el to use min-colors, so that they work on
> terminals that support 88 (or 256) colors.
> 
> This patch fixes the above issue. Is it OK? 

It's okay, provided that you checked that this:

>   (defface mode-line
> !   '((((class color) (min-colors 88))
>        :box (:line-width -1 :style released-button)
>        :background "grey75" :foreground "black")

doesn't cause any trouble on a tty because of the :box and
released-button features it uses.

Re: [patch] mode-line faces on 256-color terminals

[Dan Nicolaescu]

"Eli Zaretskii" <eliz@gnu.org> writes:

  > It's okay, provided that you checked that this:
  > 
  > >   (defface mode-line
  > > !   '((((class color) (min-colors 88))
  > >        :box (:line-width -1 :style released-button)
  > >        :background "grey75" :foreground "black")
  > 
  > doesn't cause any trouble on a tty because of the :box and
  > released-button features it uses.

Thanks. I tested it and it works fine. Committed.

Re: [patch] mode-line faces on 256-color terminals

[Richard Stallman]

Could you wait a week for the people who know the most about
face issues to comment?  If there has been no criticism in a week,
please install it, or else ask me to install it.

Re: [patch] mode-line faces on 256-color terminals

[Dan Nicolaescu]

Richard Stallman <rms@gnu.org> writes:

  > Could you wait a week for the people who know the most about
  > face issues to comment?  If there has been no criticism in a week,
  > please install it, or else ask me to install it.

Oops, I have already installed it based on Eli's OK.
What should I do, should I revert the patch now? 

Note that the patch only affects the face definitions for mode-line
and mode-line-inactive when running on terminals that support more
than 88 colors, nothing else should be affected.

Re: [patch] mode-line faces on 256-color terminals

[Richard Stallman]

      > Could you wait a week for the people who know the most about
      > face issues to comment?  If there has been no criticism in a week,
      > please install it, or else ask me to install it.

    Oops, I have already installed it based on Eli's OK.
    What should I do, should I revert the patch now? 

I think he is one of the people who ought to know.
Since he thinks it is ok, probably it is.
So you may as well leave it installed now.