all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Paul Pogonyshev <pogonyshev@gmx.net>
Cc: "Kim F. Storm" <storm@cua.dk>
Subject: `ido.el' small, but annoying bug
Date: Fri, 3 Dec 2004 20:05:53 +0200	[thread overview]
Message-ID: <200412032005.53520.pogonyshev@gmx.net> (raw)

Type `C-x b', use left/right arrow to select a different buffer
and then `C-k' to kill it.  With my Emacs (a recent CVS) the
list of buffers disappears, but can be reshown again by e.g.
pressing left/right arrow.

The following smallish patch seems to fix it.  However, `ido.el'
maintainer should certainly review it.


2004-12-03  Paul Pogonyshev  <pogonyshev@gmx.net>

	* ido.el (ido-matches): Doc fix.
	(ido-kill-buffer-at-head): Remove the killed buffer from
	`ido-matches' in addition to `ido-cur-list'.
	(ido-delete-file-at-head): Likewise for deleted file.


--- ido.el	24 Nov 2004 21:52:11 +0200	1.45
+++ ido.el	03 Dec 2004 19:59:32 +0200	
@@ -917,7 +917,7 @@ Copied from `icomplete-eoinput'.")
   "The initial string for the users string it is typed in.")
 
 (defvar ido-matches nil
-  "List of files currently matching `ido-text'.")
+  "List of files or buffers currently matching `ido-text'.")
 
 (defvar ido-report-no-match t
   "Report [No Match] when no completions matches ido-text.")
@@ -3218,7 +3218,8 @@ for first matching file."
 	  ;; buffer couldn't be killed.
 	  (setq ido-rescan t)
 	;; else buffer was killed so remove name from list.
-	(setq ido-cur-list (delq buf ido-cur-list))))))
+	(setq ido-cur-list (delq buf ido-cur-list)
+	      ido-matches  (delq buf ido-matches))))))
 
 ;;; DELETE CURRENT FILE
 (defun ido-delete-file-at-head ()
@@ -3239,7 +3240,8 @@ for first matching file."
 	  ;; file could not be deleted
 	  (setq ido-rescan t)
 	;; else file was killed so remove name from list.
-	(setq ido-cur-list (delq (car ido-matches) ido-cur-list))))))
+	(setq ido-cur-list (delq (car ido-matches) ido-cur-list)
+	      ido-matches  (cdr ido-matches))))))
 
 
 ;;; VISIT CHOSEN BUFFER

             reply	other threads:[~2004-12-03 18:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-12-03 18:05 Paul Pogonyshev [this message]
2004-12-04  0:51 ` `ido.el' small, but annoying bug Kim F. Storm
2004-12-04  1:13   ` Paul Pogonyshev
2004-12-04 18:31   ` Paul Pogonyshev
2004-12-06 13:15     ` Kim F. Storm
2004-12-06 16:25       ` Urban Engberg
2004-12-06 17:49         ` Paul Pogonyshev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200412032005.53520.pogonyshev@gmx.net \
    --to=pogonyshev@gmx.net \
    --cc=storm@cua.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.