From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: defconst in life.el Date: Sun, 14 Nov 2004 12:40:33 -0600 (CST) Message-ID: <200411141840.iAEIeXG24252@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1100457703 8336 80.91.229.6 (14 Nov 2004 18:41:43 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 14 Nov 2004 18:41:43 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 14 19:41:40 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1CTPJj-0007qE-00 for ; Sun, 14 Nov 2004 19:41:40 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTPSO-0001wL-QP for ged-emacs-devel@m.gmane.org; Sun, 14 Nov 2004 13:50:36 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CTPSA-0001vn-U5 for emacs-devel@gnu.org; Sun, 14 Nov 2004 13:50:23 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CTPS9-0001vK-Vm for emacs-devel@gnu.org; Sun, 14 Nov 2004 13:50:22 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CTPS9-0001vA-Tf for emacs-devel@gnu.org; Sun, 14 Nov 2004 13:50:21 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CTPJR-0004bw-FN for emacs-devel@gnu.org; Sun, 14 Nov 2004 13:41:21 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id iAEIfKFu010655 for ; Sun, 14 Nov 2004 12:41:21 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.7p1+Sun/8.11.7) id iAEIeXG24252; Sun, 14 Nov 2004 12:40:33 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29816 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29816 I believe all uses of defconst in life.el are wrong. Most are changed in functions in life.el itself and produce compiler warnings. Unless there are objections, I will install the following patch. My previous message to the author could not be delivered, which probably means that the file is no longer maintained. ===File ~/life.el-diff====================================== *** life.el 02 Sep 2003 07:51:42 -0500 1.20 --- life.el 14 Nov 2004 10:24:04 -0600 *************** *** 1,6 **** ;;; life.el --- John Horton Conway's `Life' game for GNU Emacs ! ;; Copyright (C) 1988, 2001 Free Software Foundation, Inc. ;; Author: Kyle Jones ;; Keywords: games --- 1,6 ---- ;;; life.el --- John Horton Conway's `Life' game for GNU Emacs ! ;; Copyright (C) 1988, 2001, 2004 Free Software Foundation, Inc. ;; Author: Kyle Jones ;; Keywords: games *************** *** 30,36 **** ;;; Code: ! (defconst life-patterns [("@@@" " @@" "@@@") ("@@@ @@@" "@@ @@ " "@@@ @@@") ("@@@ @@@" "@@ @@" "@@@ @@@") --- 30,36 ---- ;;; Code: ! (defvar life-patterns [("@@@" " @@" "@@@") ("@@@ @@@" "@@ @@ " "@@@ @@@") ("@@@ @@@" "@@ @@" "@@@ @@@") *************** *** 80,95 **** ;; list of numbers that tell how many characters to move to get to ;; each of a cell's eight neighbors. ! (defconst life-neighbor-deltas nil) ;; window display always starts here. Easier to deal with than ;; (scroll-up) and (scroll-down) when trying to center the display. ! (defconst life-window-start nil) ;; For mode line ! (defconst life-current-generation nil) ;; Sadly, mode-line-format won't display numbers. ! (defconst life-generation-string nil) (defvar life-initialized nil "Non-nil if `life' has been run at least once.") --- 80,95 ---- ;; list of numbers that tell how many characters to move to get to ;; each of a cell's eight neighbors. ! (defvar life-neighbor-deltas nil) ;; window display always starts here. Easier to deal with than ;; (scroll-up) and (scroll-down) when trying to center the display. ! (defvar life-window-start nil) ;; For mode line ! (defvar life-current-generation nil) ;; Sadly, mode-line-format won't display numbers. ! (defvar life-generation-string nil) (defvar life-initialized nil "Non-nil if `life' has been run at least once.") ============================================================