From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Pavel Kobiakov Newsgroups: gmane.emacs.devel Subject: Re: Optimizations for flymake Date: Tue, 2 Nov 2004 04:21:28 -0800 (PST) Message-ID: <20041102122128.98913.qmail@web54101.mail.yahoo.com> References: NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1099398526 6439 80.91.229.6 (2 Nov 2004 12:28:46 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 2 Nov 2004 12:28:46 +0000 (UTC) Cc: Stefan , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 02 13:28:32 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1COxm4-0006wY-00 for ; Tue, 02 Nov 2004 13:28:32 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COxu6-0003Xq-NK for ged-emacs-devel@m.gmane.org; Tue, 02 Nov 2004 07:36:50 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1COxtp-0003W1-9g for emacs-devel@gnu.org; Tue, 02 Nov 2004 07:36:33 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1COxtn-0003V2-TU for emacs-devel@gnu.org; Tue, 02 Nov 2004 07:36:32 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1COxtn-0003Uc-Po for emacs-devel@gnu.org; Tue, 02 Nov 2004 07:36:31 -0500 Original-Received: from [206.190.37.236] (helo=web54101.mail.yahoo.com) by monty-python.gnu.org with smtp (Exim 4.34) id 1COxlg-0000hZ-Ib for emacs-devel@gnu.org; Tue, 02 Nov 2004 07:28:08 -0500 Original-Received: from [212.176.3.105] by web54101.mail.yahoo.com via HTTP; Tue, 02 Nov 2004 04:21:28 PST Original-To: David Kastrup , "Kim F. Storm" In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:29319 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:29319 --- David Kastrup wrote: > storm@cua.dk (Kim F. Storm) writes: > > > Stefan writes: > > > >>> ! (defsubst flymake-makehash(&optional test) > >>> ! (if (featurep 'xemacs) > >>> ! (if test (make-hash-table :test test) > (make-hash-table)) > >>> ! (makehash test))) > >> > >> Why not (if (fboundp 'make-hash-table) ...) ? > > > > Right, that's better. > > makehash is a compiled Lisp function in `subr'. > (makehash &optional TEST) > > This function is obsolete since 21.4; > use `make-hash-table' instead. > > Not documented. > > [back] > > In short, just rip out the test and always use > make-hash-table. > > -- > David Kastrup, Kriemhildstr. 15, 44793 Bochum > Getting rid of makehash won't allow Flymake to run on older versions of Emacs, so I think it's not a good idea. Pasha. __________________________________ Do you Yahoo!? Check out the new Yahoo! Front Page. www.yahoo.com