Re: Optimizations for flymake

[Pavel Kobiakov <pk_at_work@yahoo.com>]

--- David Kastrup <dak@gnu.org> wrote:
> storm@cua.dk (Kim F. Storm) writes:
> 
> > Stefan <monnier@iro.umontreal.ca> writes:
> >
> >>> ! (defsubst flymake-makehash(&optional test)
> >>> !   (if (featurep 'xemacs)
> >>> !       (if test (make-hash-table :test test)
> (make-hash-table))
> >>> !     (makehash test)))
> >>
> >> Why not (if (fboundp 'make-hash-table) ...) ?
> >
> > Right, that's better.
> 
> makehash is a compiled Lisp function in `subr'.
> (makehash &optional TEST)
> 
> This function is obsolete since 21.4;
> use `make-hash-table' instead.
> 
> Not documented.
> 
> [back]
> 
> In short, just rip out the test and always use
> make-hash-table.
> 
> -- 
> David Kastrup, Kriemhildstr. 15, 44793 Bochum
> 

Getting rid of makehash won't allow Flymake to run on
older versions of Emacs, so I think it's not a good
idea.

  Pasha.



		
__________________________________ 
Do you Yahoo!? 
Check out the new Yahoo! Front Page. 
www.yahoo.com