From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: global-autorevert-mode does not preserve read-only status Date: Wed, 1 Sep 2004 12:52:24 -0500 (CDT) Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <200409011752.i81HqOP16312@raven.dms.auburn.edu> References: <87oekrk3a1.fsf@cante.net> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1094061212 15315 80.91.224.253 (1 Sep 2004 17:53:32 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 1 Sep 2004 17:53:32 +0000 (UTC) Cc: rms@gnu.org, jari.aalto@poboxes.com, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 01 19:53:10 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1C2ZIC-0005GA-00 for ; Wed, 01 Sep 2004 19:53:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C2ZN8-0005HN-JM for ged-emacs-devel@m.gmane.org; Wed, 01 Sep 2004 13:58:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1C2ZMy-0005FW-B3 for emacs-devel@gnu.org; Wed, 01 Sep 2004 13:58:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1C2ZMx-0005FD-4v for emacs-devel@gnu.org; Wed, 01 Sep 2004 13:58:03 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1C2ZMw-0005F8-VC for emacs-devel@gnu.org; Wed, 01 Sep 2004 13:58:03 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1C2ZHw-00020V-Ob; Wed, 01 Sep 2004 13:52:53 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i81HqjuE015057; Wed, 1 Sep 2004 12:52:46 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i81HqOP16312; Wed, 1 Sep 2004 12:52:24 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: monnier@iro.umontreal.ca In-reply-to: (message from Stefan Monnier on 01 Sep 2004 10:32:47 -0400) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:26699 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:26699 Stefan Monnier wrote: > I think the state should be preserved as user had set it. > For Autorevert mode, I agree. Isn't that already the case in CVS? No. (But it is true for`auto-revert-tail-mode'.) I seem to remeber changing auto-revert-mode so as to pass the `preserve-modes' argument to revert-buffer, specifically to fix this problem. `after-find-file' resets buffer-read-only regardless of its NOMODES argument. The following trivial patch makes autorevert preserve read-onlyness. I could install if there are no objections. ===File ~/autorevert-diff=================================== *** autorevert.el 24 Jul 2004 10:28:56 -0500 1.37 --- autorevert.el 01 Sep 2004 12:14:17 -0500 *************** *** 421,427 **** 'no-mini t)) (if auto-revert-tail-mode (auto-revert-tail-handler) ! (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes)) (when buffer-file-name (when eob (goto-char (point-max))) (dolist (window eoblist) --- 421,428 ---- 'no-mini t)) (if auto-revert-tail-mode (auto-revert-tail-handler) ! (let ((buffer-read-only buffer-read-only)) ! (revert-buffer 'ignore-auto 'dont-ask 'preserve-modes))) (when buffer-file-name (when eob (goto-char (point-max))) (dolist (window eoblist) ============================================================