color-gray-p

color-gray-p

[Devon Sean McCullough]

In GNU Emacs 21.3.3 (i386-unknown-freebsd4.8, X toolkit, Xaw3d scroll bars)
 of 2003-06-08 on grant.org
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  locale-coding-system: nil
  default-enable-multibyte-characters: t

Please describe exactly what actions triggered the bug
and the precise symptoms of the bug:

(color-gray-p "gray") signals (wrong-type-argument framep nil)

Functions `color-gray-p' and `color-supported-p'
do not work as documented.  See patch to xfaces.c
below which seems to correct the trouble although
much is obscure to me, e.g. the second parameter
of CHECK_* is a total mystery.

Recent input:
( c o l o r - g r ESC TAB SPC " g r a y " ) C-j ESC 
x r e p o r t SPC e m SPC SPC RET

Recent messages:
(emacs -q)
For information about the GNU Project and its goals, type C-h C-p.
eval: 
Loading debug...done
Entering debugger...
 [2 times]
Loading emacsbug...done

--- emacs-21.3/src/xfaces.c.~1~	Thu Nov 14 08:15:48 2002
+++ emacs-21.3/src/xfaces.c	Fri Aug 20 13:22:13 2004
@@ -1476,15 +1476,17 @@
 {
   struct frame *f;
 
-  CHECK_FRAME (frame, 0);
   CHECK_STRING (color, 0);
+  if (NILP (frame))
+    frame = selected_frame;
+  CHECK_FRAME (frame, 0);
   f = XFRAME (frame);
   return face_color_gray_p (f, XSTRING (color)->data) ? Qt : Qnil;
 }
 
 
 DEFUN ("color-supported-p", Fcolor_supported_p,
-       Scolor_supported_p, 2, 3, 0,
+       Scolor_supported_p, 1, 3, 0,
   "Return non-nil if COLOR can be displayed on FRAME.\n\
 BACKGROUND-P non-nil means COLOR is used as a background.\n\
 If FRAME is nil or omitted, use the selected frame.\n\
@@ -1494,8 +1496,10 @@
 {
   struct frame *f;
 
-  CHECK_FRAME (frame, 0);
   CHECK_STRING (color, 0);
+  if (NILP (frame))
+    frame = selected_frame;
+  CHECK_FRAME (frame, 0);
   f = XFRAME (frame);
   if (face_color_supported_p (f, XSTRING (color)->data, !NILP (background_p)))
     return Qt;

color-gray-p

[Luc Teirlinck]

Devon Sean McCullough wrote:

    (color-gray-p "gray") signals (wrong-type-argument framep nil)

    Functions `color-gray-p' and `color-supported-p'
    do not work as documented.

These bugs occurred in 21.3, but they are fixed in Emacs CVS and,
hence, will be fixed in 21.4 (not yet released).

Sincerely,

Luc.

Re: color-gray-p

[Devon]

Thanks.  Where do I get Emacs CVS?  I know how to FTP but I understand
you have to undergo secret initiation rites at Unix Summer Camp before
CVS will deign to fetch you any software.

		Peace
			--Devon
	 /~\
	 \ /	Health Care
	  X	not warfare
	 / \

	The Voting Machine Industry
	has a surprise in store:
	Kevin Mitnick in 2004!

PS:  What about CHECK_* and other mysteries?
Has anyone written this down or must I go to
a certain tavern and buy RMS a beer to learn
such arcana?

Date: Sun, 22 Aug 2004 11:36:44 -0500 (CDT)
From: Luc Teirlinck <teirllm@dms.auburn.edu>
To: Devon Sean McCullough <gnu-emacs-hacker@jovi.net>
CC: bug-gnu-emacs@gnu.org
Subject: color-gray-p

Devon Sean McCullough wrote:

    (color-gray-p "gray") signals (wrong-type-argument framep nil)

    Functions `color-gray-p' and `color-supported-p'
    do not work as documented.

These bugs occurred in 21.3, but they are fixed in Emacs CVS and,
hence, will be fixed in 21.4 (not yet released).

Sincerely,

Luc.

Re: color-gray-p

[Luc Teirlinck]

Devon Sean McCullough wrote:

   Thanks.  Where do I get Emacs CVS?  I know how to FTP but I understand
   you have to undergo secret initiation rites at Unix Summer Camp before
   CVS will deign to fetch you any software.

It is a while ago that I used _anonymous_ CVS, but I believe that all
you have to do is:

    export CVS_RSH="ssh"

    cvs -z3 -d:ext:anoncvs@savannah.gnu.org:/webcvs/emacs co emacs

When prompted for a password for anoncvs, simply press the Enter key.

You might first want to take a look at:

http://savannah.gnu.org/cvs/?group=emacs

where you can find more details.

Sincerely,

Luc.

Re: color-gray-p

[Luc Teirlinck]

>From my previous message:

    cvs -z3 -d:ext:anoncvs@savannah.gnu.org:/webcvs/emacs co emacs

No, I cut and pasted the wrong one.  Savannah appears to be down now,
but I believe it is:

    cvs -z3 -d:ext:anoncvs@savannah.gnu.org:/cvsroot/emacs co emacs

Anyway, it is all at:

http://savannah.gnu.org/cvs/?group=emacs

(But right now the Savannah website appears to be down for upgrade.)

Sincerely,

Luc.

Re: color-gray-p

[Luc Teirlinck]

Devon Sean McCullough wrote:

   PS:  What about CHECK_* and other mysteries?
   Has anyone written this down or must I go to
   a certain tavern and buy RMS a beer to learn
   such arcana?

As far as I know, the only documentation about the Emacs C code is
contained in Info node `(elisp)GNU Emacs Internals' or Appendix E, GNU
Emacs Internals, in the hardcopy Elisp manual.

This is _not at all_ a comprehensive documentation.  As far as I know,
to learn the Emacs C code, you essentially have to struggle through the
source code.

In as far as the second argument to the CHECK_* functions is
concerned, it seems to have been removed in current CVS.  It
definitely has been removed for CHECK_FRAME.

Sincerely,

Luc.

Re: color-gray-p

[Devon]

Thanks, your first suggestion is sucking down bits even as we type.

 14:08:55 Sun Aug 22
devon@gr:~/gnumacs/$ cvs -z3 -d:ext:anoncvs@savannah.gnu.org:/webcvs/emacs co emacs
The authenticity of host 'savannah.gnu.org (199.232.41.3)' can't be established.
DSA key fingerprint is 4d:c8:dc:9a:99:96:ae:cc:ce:d3:2b:b0:a3:a4:95:a5.
Are you sure you want to continue connecting (yes/no)? yes

Warning: Permanently added 'savannah.gnu.org' (DSA) to the list of known hosts.
cvs checkout: Updating emacs
U emacs/.symlinks
U emacs/NEWS.20.4
...

Re: color-gray-p

[Devon]

...
U emacs/elisp-manual-20-2.5/elisp_html_node.tar.gz
U emacs/elisp-manual-20-2.5/index.html
cvs [checkout aborted]: could not chdir to /home1/devon/gnumacs: No such file or directory

It croaked because I renamed a parent directory from gnumacs to gnu,
so far only HTML, mere texi2html output, not even the TEX manual
source, the C and LISP sources are in there someplace, right?

Do I have to download everying all over again now?

Re: color-gray-p

[Luc Teirlinck]

   ...
   U emacs/elisp-manual-20-2.5/elisp_html_node.tar.gz
   U emacs/elisp-manual-20-2.5/index.html
   cvs [checkout aborted]: could not chdir to /home1/devon/gnumacs: No such file or directory

   It croaked because I renamed a parent directory from gnumacs to gnu,
   so far only HTML, mere texi2html output, not even the TEX manual
   source, the C and LISP sources are in there someplace, right?

   Do I have to download everying all over again now?

Sorry, I accidentally cut and pasted the wrong thing, as I
explained in my second mail.  The correct instruction is:

cvs -z3 -d:ext:anoncvs@savannah.gnu.org:/cvsroot/emacs co emacs

They are so similar that I did not immediately notice.  I sent you the
second mail as soon as I did.

You also need version 4.2 or later of Texinfo.
You can check your version with:
info --version

Sincerely,

Luc.

Re: color-gray-p

[Devon]

OK, yeah babe!  That's more like it.  Thanks again.

		Peace
			--Devon

PS: So tired of Emacs Lisp, I'll switch to SNOBOL4,
same vintage, far better for parser & editor hacks.
Multibyte &ALPHABET likely to be smoke and mirrors.

Re: color-gray-p

[Luc Teirlinck]

Did you actually manage to bootstrap?  Failed for me with the latest
sources.  There seems to be a problem in speedbar.el.  That sometimes
happens with the CVS version (luckily not too excessively often).

Note that you will not have to download everything back again to get
the corrected version.  Only files that need updating get updated.

Sincerely,

Luc.

Re: color-gray-p

[Luc Teirlinck]

If you did have problems bootstrapping, they should be fixed now.

Sincerely,

Luc.