From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Fix `window-at' and `coordinates-in-window-p' Date: Sat, 24 Jul 2004 09:30:52 -0500 (CDT) Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Message-ID: <200407241430.i6OEUqv27206@raven.dms.auburn.edu> References: NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1090679688 14333 80.91.224.253 (24 Jul 2004 14:34:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 24 Jul 2004 14:34:48 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jul 24 16:34:35 2004 Return-path: Original-Received: from lists.gnu.org ([199.232.76.165]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BoNbf-00031r-00 for ; Sat, 24 Jul 2004 16:34:35 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BoNeb-0005FH-5y for ged-emacs-devel@m.gmane.org; Sat, 24 Jul 2004 10:37:37 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BoNeT-0005EU-LV for emacs-devel@gnu.org; Sat, 24 Jul 2004 10:37:29 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BoNeS-0005EB-28 for emacs-devel@gnu.org; Sat, 24 Jul 2004 10:37:29 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BoNeR-0005E8-VA for emacs-devel@gnu.org; Sat, 24 Jul 2004 10:37:28 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BoNbG-0004WE-OS for emacs-devel@gnu.org; Sat, 24 Jul 2004 10:34:10 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i6OEY1uE029569; Sat, 24 Jul 2004 09:34:01 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i6OEUqv27206; Sat, 24 Jul 2004 09:30:52 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: lorentey@elte.hu In-reply-to: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25922 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25922 After taking a closer look at your patch, I guess one would have to be careful that there are no functions calling the functions you changed that _already_ adjust for FRAME_INTERNAL_BORDER_WIDTH, in which case they will double-adjust after the patch. I did not find any, but I have not looked that carefully. I guess an alternative would be to make the adjustment inside `window-at' and `coordinates-in-window-p'. A patch that Richard sent me and that does this for `window-at' strangely enough seems to fail by making `window-at' return nil everywhere: *** window.c 20 Jul 2004 16:52:30 -0400 1.471 --- window.c 23 Jul 2004 20:05:29 -0400 *************** *** 937,944 **** CHECK_NUMBER_OR_FLOAT (y); return window_from_coordinates (f, ! FRAME_PIXEL_X_FROM_CANON_X (f, x), ! FRAME_PIXEL_Y_FROM_CANON_Y (f, y), 0, 0, 0, 0); } --- 937,946 ---- CHECK_NUMBER_OR_FLOAT (y); return window_from_coordinates (f, ! (FRAME_PIXEL_X_FROM_CANON_X (f, x) ! + FRAME_INTERNAL_BORDER_WIDTH (f)), ! (FRAME_PIXEL_Y_FROM_CANON_Y (f, y) ! + FRAME_INTERNAL_BORDER_WIDTH (f)), 0, 0, 0, 0); }