From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: time values Date: Sun, 11 Jul 2004 10:57:00 -0500 (CDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200407111557.i6BFv0n09288@raven.dms.auburn.edu> References: <200407110033.i6B0XLF08165@raven.dms.auburn.edu> <86llhrq7ed.fsf@rumba.de.uu.net> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1089561739 20123 80.91.224.253 (11 Jul 2004 16:02:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sun, 11 Jul 2004 16:02:19 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Jul 11 18:02:15 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BjgmN-0003o5-00 for ; Sun, 11 Jul 2004 18:02:15 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BjgmN-0004b3-00 for ; Sun, 11 Jul 2004 18:02:15 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1Bjgoe-0001ei-29 for emacs-devel@quimby.gnus.org; Sun, 11 Jul 2004 12:04:36 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BjgmG-0000Q7-Ia for emacs-devel@gnu.org; Sun, 11 Jul 2004 12:02:08 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BjgmF-0000Pd-RN for emacs-devel@gnu.org; Sun, 11 Jul 2004 12:02:08 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BjgmF-0000PV-NZ for emacs-devel@gnu.org; Sun, 11 Jul 2004 12:02:07 -0400 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.34) id 1Bjgjs-00004v-G0 for emacs-devel@gnu.org; Sun, 11 Jul 2004 11:59:40 -0400 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i6BFxcuE013795; Sun, 11 Jul 2004 10:59:38 -0500 (CDT) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i6BFv0n09288; Sun, 11 Jul 2004 10:57:00 -0500 (CDT) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: kai@emptydomain.de In-reply-to: <86llhrq7ed.fsf@rumba.de.uu.net> (message from Kai Grossjohann on Sun, 11 Jul 2004 10:23:38 +0200) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25583 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25583 I do not see why `visited-file-modtime could not be 0 at that point. What about the following: ===File ~/tramp-diff-3====================================== *** tramp.el 26 Jun 2004 16:46:18 -0500 1.46 --- tramp.el 11 Jul 2004 10:43:12 -0500 *************** *** 2337,2349 **** (with-parsed-tramp-file-name f nil (let* ((attr (file-attributes f)) (modtime (nth 5 attr))) ! (cond ((and attr (not (equal modtime '(0 0)))) ! ;; Why does `file-attributes' return a list (HIGH ! ;; LOW), but `visited-file-modtime' returns a cons ! ;; (HIGH . LOW)? (let ((mt (visited-file-modtime))) (< (abs (tramp-time-diff ! modtime (list (car mt) (cdr mt)))) 2))) (attr (save-excursion (tramp-send-command --- 2337,2354 ---- (with-parsed-tramp-file-name f nil (let* ((attr (file-attributes f)) (modtime (nth 5 attr))) ! (cond ((eq (visited-file-modtime) 0)) ! ((and attr (not (equal modtime '(0 0)))) (let ((mt (visited-file-modtime))) (< (abs (tramp-time-diff ! modtime ! ;; For compatibility, deal with both the old ! ;; (HIGH . LOW) and the new (HIGH LOW) ! ;; return values of `visited-file-modtime'. ! (if (and (consp mt) (atom (cdr mt))) ! (list (car mt) (cdr mt)) ! mt))) ! 2))) (attr (save-excursion (tramp-send-command ============================================================