Cannot copy/cut from emacs

Cannot copy/cut from emacs

[Tak Ota]

2004-07-01  Kenichi Handa  <handa@m17n.org>

	* w32select.c (Fw32_set_clipboard_data): Update `nbytes' correctly
	after getting a new string by pre-write-conversion.

This change breaks copying from emacs to the system clipboard.
The newly added following "+ 1" garble the clipboard content when
emacs performs kill/copy operation.

            nbytes = SBYTES (string) + 1;

Removing the "+ 1" restores the correct operation.

Re: Cannot copy/cut from emacs

[Kenichi Handa]

In article <20040702.091153.01370603.Takaaki.Ota@am.sony.com>, Tak Ota <Takaaki.Ota@am.sony.com> writes:

> 2004-07-01  Kenichi Handa  <handa@m17n.org>
> 	* w32select.c (Fw32_set_clipboard_data): Update `nbytes' correctly
> 	after getting a new string by pre-write-conversion.

> This change breaks copying from emacs to the system clipboard.
> The newly added following "+ 1" garble the clipboard content when
> emacs performs kill/copy operation.

>             nbytes = SBYTES (string) + 1;

> Removing the "+ 1" restores the correct operation.

Hmm, strange.  How does it "garble the clipboard content"?

At the beginning of Fw32_set_clipboard_data, nbytes is set
as this:

  nbytes = SBYTES (string) + 1;

So, I installed the above change to make nbytes contain the
terminating null even when pre-write-conversion is called.

Please try:

(coding-system-put selection-coding-sytem 'pre-write-conversion nil)

Does it change the behaviour?

---
Ken'ichi HANDA
handa@m17n.org

Re: Cannot copy/cut from emacs

[Tak Ota]

After rebuilding emacs with your change again I'm having hard time
reproducing the problem.  Let me spend some more time on this.

-Tak

Sat, 3 Jul 2004 09:14:10 +0900 (JST): Kenichi Handa <handa@m17n.org> wrote:

> In article <20040702.091153.01370603.Takaaki.Ota@am.sony.com>, Tak Ota <Takaaki.Ota@am.sony.com> writes:
> 
> > 2004-07-01  Kenichi Handa  <handa@m17n.org>
> > 	* w32select.c (Fw32_set_clipboard_data): Update `nbytes' correctly
> > 	after getting a new string by pre-write-conversion.
> 
> > This change breaks copying from emacs to the system clipboard.
> > The newly added following "+ 1" garble the clipboard content when
> > emacs performs kill/copy operation.
> 
> >             nbytes = SBYTES (string) + 1;
> 
> > Removing the "+ 1" restores the correct operation.
> 
> Hmm, strange.  How does it "garble the clipboard content"?
> 
> At the beginning of Fw32_set_clipboard_data, nbytes is set
> as this:
> 
>   nbytes = SBYTES (string) + 1;
> 
> So, I installed the above change to make nbytes contain the
> terminating null even when pre-write-conversion is called.
> 
> Please try:
> 
> (coding-system-put selection-coding-sytem 'pre-write-conversion nil)
> 
> Does it change the behaviour?
> 
> ---
> Ken'ichi HANDA
> handa@m17n.org

Re: Cannot copy/cut from emacs

[Tak Ota]

Sorry it must have been a false alarm since I no longer be able to
reproduce the problem.  However, I DID have the problem in
copying/cutting from emacs right after updating from the CVS which
included your change.

Please forget about this for now.

-Tak

Fri, 02 Jul 2004 18:01:40 -0700 (PDT): Tak Ota <Takaaki.Ota@am.sony.com> wrote:

> After rebuilding emacs with your change again I'm having hard time
> reproducing the problem.  Let me spend some more time on this.
> 
> -Tak
> 
> Sat, 3 Jul 2004 09:14:10 +0900 (JST): Kenichi Handa <handa@m17n.org> wrote:
> 
> > In article <20040702.091153.01370603.Takaaki.Ota@am.sony.com>, Tak Ota <Takaaki.Ota@am.sony.com> writes:
> > 
> > > 2004-07-01  Kenichi Handa  <handa@m17n.org>
> > > 	* w32select.c (Fw32_set_clipboard_data): Update `nbytes' correctly
> > > 	after getting a new string by pre-write-conversion.
> > 
> > > This change breaks copying from emacs to the system clipboard.
> > > The newly added following "+ 1" garble the clipboard content when
> > > emacs performs kill/copy operation.
> > 
> > >             nbytes = SBYTES (string) + 1;
> > 
> > > Removing the "+ 1" restores the correct operation.
> > 
> > Hmm, strange.  How does it "garble the clipboard content"?
> > 
> > At the beginning of Fw32_set_clipboard_data, nbytes is set
> > as this:
> > 
> >   nbytes = SBYTES (string) + 1;
> > 
> > So, I installed the above change to make nbytes contain the
> > terminating null even when pre-write-conversion is called.
> > 
> > Please try:
> > 
> > (coding-system-put selection-coding-sytem 'pre-write-conversion nil)
> > 
> > Does it change the behaviour?
> > 
> > ---
> > Ken'ichi HANDA
> > handa@m17n.org
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel