From: Juanma Barranquero <jmbarranquero@wke.es>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Delayed loading of image libraries
Date: Wed, 30 Jun 2004 15:00:30 +0200 [thread overview]
Message-ID: <20040630142515.BD13.JMBARRANQUERO@wke.es> (raw)
In-Reply-To: <je3c4db7cw.fsf@sykes.suse.de>
On Wed, 30 Jun 2004 13:41:51 +0200
Andreas Schwab <schwab@suse.de> wrote:
> Would Qnil be valid in this context? Certainly for !HAVE_NTGUI, but would
> that work for HAVE_NTGUI?
Passing Qnil should work. However, Miles' change doesn't seem to be
right, even when passing Qnil to Finit_image_library. make_image does:
img->type = lookup_image_type (image_spec_value (spec, QCtype, NULL));
xassert (img->type != NULL);
and, from what I gather, xassert can be a null op**, in which case an
image is built with a non-valid type.
In fact, I'm not sure why lookup_image_type is supposed to allow
returning NULL. It is an internal function to map image type symbols to
image type structs, so the image type symbol validation should be done
at a higher level (before calling lookup_image_type).
**BTW, what is xassert supposed to do? On dispextern.h it is a null op
unless GLYPH_DEBUG is defined; and fontset.c has its own definition.
Juanma
next prev parent reply other threads:[~2004-06-30 13:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-10 12:38 [PATCH] Delayed loading of image libraries Juanma Barranquero
2004-06-30 10:15 ` Andreas Schwab
2004-06-30 11:13 ` Juanma Barranquero
2004-06-30 11:24 ` Andreas Schwab
2004-06-30 11:34 ` Juanma Barranquero
2004-06-30 11:41 ` Andreas Schwab
2004-06-30 13:00 ` Juanma Barranquero [this message]
2004-06-30 15:42 ` Miles Bader
2004-07-01 9:30 ` Juanma Barranquero
2004-07-01 9:48 ` Miles Bader
2004-07-01 10:13 ` Juanma Barranquero
2004-07-02 1:16 ` Miles Bader
2004-07-02 7:02 ` Juanma Barranquero
2004-07-02 7:10 ` David Kastrup
2004-07-02 7:41 ` Juanma Barranquero
2004-07-02 7:56 ` Miles Bader
2004-07-02 8:10 ` Juanma Barranquero
2004-07-02 8:20 ` Miles Bader
2004-07-02 8:45 ` Juanma Barranquero
2004-07-02 8:59 ` Miles Bader
2004-07-02 9:02 ` Miles Bader
2004-07-02 8:11 ` David Kastrup
2004-07-02 8:34 ` Juanma Barranquero
2004-07-03 18:21 ` Richard Stallman
2004-06-30 14:19 ` Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040630142515.BD13.JMBARRANQUERO@wke.es \
--to=jmbarranquero@wke.es \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.