From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Two questions about thumbs.el Date: Mon, 26 Apr 2004 15:31:02 +0200 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <20040426104147.5042.JMBARRANQUERO@wke.es> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1082988069 693 80.91.224.253 (26 Apr 2004 14:01:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 26 Apr 2004 14:01:09 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Apr 26 16:00:54 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BI6fG-0004lC-00 for ; Mon, 26 Apr 2004 16:00:54 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BI6fG-0001sD-00 for ; Mon, 26 Apr 2004 16:00:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BI6eV-0000R6-NU for emacs-devel@quimby.gnus.org; Mon, 26 Apr 2004 10:00:07 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BI6QO-0005DO-Jm for emacs-devel@gnu.org; Mon, 26 Apr 2004 09:45:32 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BI6Pc-0004fx-LK for emacs-devel@gnu.org; Mon, 26 Apr 2004 09:45:16 -0400 Original-Received: from [62.22.181.117] (helo=idefix.laley.net) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BI6CR-0000GZ-Mm for emacs-devel@gnu.org; Mon, 26 Apr 2004 09:31:07 -0400 Original-Received: from [172.17.221.23] (jsredondo.wk.org [172.17.221.23]) by idefix.laley.net with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2655.55) id JN3LJTRY; Mon, 26 Apr 2004 15:30:44 +0200 Original-To: emacs-devel@gnu.org X-Mailer: Becky! ver. 2.08.01 [en] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:22171 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:22171 Fist: There are a few .el files with no copyright and no comment about them being in the public domain. Most of them are quite small or even trivial: forms-d2.el forms-pass.el patcomp.el obsolete/sc.el term/apollo.el term/bobcat.el term/vt*.el but thumbs.el is a 700+ lines file. Shouldn't it have a copyright line? Now, the real question: (when (not (fboundp 'time-less-p)) (defun time-less-p (t1 t2) "Say whether time T1 is less than time T2." (or (< (car t1) (car t2)) (and (= (car t1) (car t2)) (< (nth 1 t1) (nth 1 t2)))))) This code introduces a symbol time-less-p, which could confuse feature checks. Wouldn't it be better: (if (fboundp 'time-less-p) (defalias 'thumbs-time-less-p 'time-less-p) (defun thumbs-time-less-p (t1 t2) "Say whether time T1 is less than time T2." (or (< (car t1) (car t2)) (and (= (car t1) (car t2)) (< (nth 1 t1) (nth 1 t2))))))) Third question (yeah, I lied on the subject): There are at least eight versions of the time-less-p code: calendar/time-date: time-less-p calendar/timeclock: timeclock-time-less-p pcomplete: pcomplete-time-less-p speedbar: speedbar-check-obj-this-line (fragment) thumbs: time-less-p autoload: autoload-before-p eshell/esh-util: eshell-time-less-p net/tramp-smb: tramp-smb-time-less-p (fragment) speedbar, eshell and tramp have a life outside of Emacs, so they need their own definitions for compatibility, but the others could be "reunified" by using calendar/time-date's version (time-date.elc is quite small, about 4K). Is there any reason not to do it, other than not wanting them to load calendar/time-date.elc? Note: I'm not sure about autoload, because without testing it I don't know if there'll be a problem for autoload to use an autoloaded function. Juanma