From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: autorevert.el Date: Thu, 25 Mar 2004 00:49:18 -0600 (CST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200403250649.i2P6nIH12878@raven.dms.auburn.edu> References: <200403022319.i22NJbG01259@raven.dms.auburn.edu> <200403040508.i2458W811551@raven.dms.auburn.edu> <200403050400.i2540VQ21715@raven.dms.auburn.edu> <200403130310.i2D3A8w28676@raven.dms.auburn.edu> <200403150008.i2F083x04382@raven.dms.auburn.edu> <200403160456.i2G4uVL14097@raven.dms.auburn.edu> <2427-Tue16Mar2004214034+0200-eliz@elta.co.il> <8011-Fri19Mar2004164602+0200-eliz@elta.co.il> <200403210326.i2L3QpF29260@raven.dms.auburn.edu> <200403220244.i2M2ikR07506@raven.dms.auburn.edu> <200403221939.i2MJd8116508@raven.dms.auburn.edu> <8296-Tue23Mar2004214028+0200-eliz@elta.co.il> <2004032404 NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1080198262 22101 80.91.224.253 (25 Mar 2004 07:04:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 25 Mar 2004 07:04:22 +0000 (UTC) Cc: eliz@gnu.org, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Mar 25 08:04:13 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B6OuT-0005q7-00 for ; Thu, 25 Mar 2004 08:04:13 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B6OuT-0000UW-00 for ; Thu, 25 Mar 2004 08:04:13 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B6OoM-0004Wk-RD for emacs-devel@quimby.gnus.org; Thu, 25 Mar 2004 01:57:54 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B6Olq-0003du-VK for emacs-devel@gnu.org; Thu, 25 Mar 2004 01:55:18 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B6OlJ-0003NQ-Fa for emacs-devel@gnu.org; Thu, 25 Mar 2004 01:55:17 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B6Ohw-0002YE-R7; Thu, 25 Mar 2004 01:51:16 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i2P6pBKt027903; Thu, 25 Mar 2004 00:51:11 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i2P6nIH12878; Thu, 25 Mar 2004 00:49:18 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: teirllm@dms.auburn.edu In-reply-to: <200403250620.i2P6KKE12816@raven.dms.auburn.edu> (message from Luc Teirlinck on Thu, 25 Mar 2004 00:20:20 -0600 (CST)) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20872 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20872 The following appears to be better than my original patch (stylistic improvement, not bug fix): ===File ~/dired-diff======================================== diff -c /home/teirllm/dired.old.el /home/teirllm/emacscvsdir/emacs/lisp/dired.el *** /home/teirllm/dired.old.el Wed Mar 24 22:07:09 2004 --- /home/teirllm/emacscvsdir/emacs/lisp/dired.el Thu Mar 25 00:39:40 2004 *************** *** 525,530 **** --- 525,538 ---- (setq dir-or-list dirname)) (dired-internal-noselect dir-or-list switches))) + (defvar dired-directory-size nil + "Internal variable used by dired on certain operating systems. + On ms-dos, the value is the sum of all file lenghts in the directory. + On other operating systems, the value may have a different meaning + or be meaningless.") + + (put 'dired-directory-size 'permanent-local t) + ;; The following is an internal dired function. It returns non-nil if ;; the directory visited by the current dired buffer has changed on ;; disk. DIRNAME should be the directory name of that directory. *************** *** 534,540 **** (or (eq modtime 0) (not (eq (car attributes) t)) (and (= (car (nth 5 attributes)) (car modtime)) ! (= (nth 1 (nth 5 attributes)) (cdr modtime))))))) (defun dired-buffer-stale-p (&optional noconfirm) "Return non-nil if current dired buffer needs updating. --- 542,552 ---- (or (eq modtime 0) (not (eq (car attributes) t)) (and (= (car (nth 5 attributes)) (car modtime)) ! (= (nth 1 (nth 5 attributes)) (cdr modtime)) ! (if (eq system-type 'ms-dos) ! ;; This does not work perfectly. ! (= dired-directory-size (nth 7 attributes)) ! t)))))) (defun dired-buffer-stale-p (&optional noconfirm) "Return non-nil if current dired buffer needs updating. *************** *** 678,685 **** (set (make-local-variable 'dired-subdir-alist) nil) (dired-build-subdir-alist) (let ((attributes (file-attributes dirname))) ! (if (eq (car attributes) t) ! (set-visited-file-modtime (nth 5 attributes)))) (set-buffer-modified-p nil) ;; No need to narrow since the whole buffer contains just ;; dired-readin's output, nothing else. The hook can --- 690,699 ---- (set (make-local-variable 'dired-subdir-alist) nil) (dired-build-subdir-alist) (let ((attributes (file-attributes dirname))) ! (when (eq (car attributes) t) ! (set-visited-file-modtime (nth 5 attributes)) ! (set (make-local-variable 'dired-directory-size) ! (nth 7 attributes)))) (set-buffer-modified-p nil) ;; No need to narrow since the whole buffer contains just ;; dired-readin's output, nothing else. The hook can Diff finished. Thu Mar 25 00:40:04 2004 ============================================================