From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: autorevert.el Date: Sun, 14 Mar 2004 18:08:03 -0600 (CST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200403150008.i2F083x04382@raven.dms.auburn.edu> References: <200403022319.i22NJbG01259@raven.dms.auburn.edu> <200403040508.i2458W811551@raven.dms.auburn.edu> <200403050400.i2540VQ21715@raven.dms.auburn.edu> <200403130310.i2D3A8w28676@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1079309642 10333 80.91.224.253 (15 Mar 2004 00:14:02 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 15 Mar 2004 00:14:02 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Mar 15 01:13:52 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B2fjs-0004rk-00 for ; Mon, 15 Mar 2004 01:13:52 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B2fjs-00086x-00 for ; Mon, 15 Mar 2004 01:13:52 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B2fgS-0006ww-NI for emacs-devel@quimby.gnus.org; Sun, 14 Mar 2004 19:10:20 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1B2fgL-0006tD-GL for emacs-devel@gnu.org; Sun, 14 Mar 2004 19:10:13 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1B2ffp-0006X4-0l for emacs-devel@gnu.org; Sun, 14 Mar 2004 19:10:12 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B2ffk-0006SY-5M for emacs-devel@gnu.org; Sun, 14 Mar 2004 19:09:36 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i2F09VKt022328; Sun, 14 Mar 2004 18:09:31 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i2F083x04382; Sun, 14 Mar 2004 18:08:03 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: monnier@iro.umontreal.ca In-reply-to: (message from Stefan Monnier on 14 Mar 2004 18:15:54 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20474 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20474 Stefan Monnier wrote: How does the code figure out whether auto-reverting the buffer is needed? I mean, there's no visited-time to check, right? For dired buffers, visited-file-modtime works, even though verify-visited-file-modtime does not. For non-file, non-vc, non-dired buffers, the current code just reverts every auto-revert-interval seconds without checking whether reverting is actually needed. For most of these buffers we might actually have to keep things that way, since checking whether the buffer needs reverting could easily take longer than reverting it. So maybe we should add a `auto-revert-stale-function' which dired and buffer-menu can set. This will clean up the current staleness checking function since it will only have to work for file-buffers, and will make sure that revert-buffer-function is only called by auto-revert for modes which have auto-revert support. I will try to make the buffer-menu auto-revert in a non-obnoxious way and see how things work out. Sincerely, Luc.