From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.devel Subject: Re: autorevert.el Date: Thu, 4 Mar 2004 22:00:31 -0600 (CST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200403050400.i2540VQ21715@raven.dms.auburn.edu> References: <200403022319.i22NJbG01259@raven.dms.auburn.edu> <200403040508.i2458W811551@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1078759756 791 80.91.224.253 (8 Mar 2004 15:29:16 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 8 Mar 2004 15:29:16 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Mon Mar 08 16:29:09 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1B0Mgn-0003sN-00 for ; Mon, 08 Mar 2004 16:29:09 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1B0Mgn-0006p0-00 for ; Mon, 08 Mar 2004 16:29:09 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1B0MfH-0002Pr-Ob for emacs-devel@quimby.gnus.org; Mon, 08 Mar 2004 10:27:35 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1Az6XO-0004C4-6W for emacs-devel@gnu.org; Thu, 04 Mar 2004 23:02:14 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1Az6Wq-0003vu-HZ for emacs-devel@gnu.org; Thu, 04 Mar 2004 23:02:11 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.30) id 1Az6Wq-0003vr-2H for emacs-devel@gnu.org; Thu, 04 Mar 2004 23:01:40 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i2541aKt013712; Thu, 4 Mar 2004 22:01:36 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i2540VQ21715; Thu, 4 Mar 2004 22:00:31 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: monnier@iro.umontreal.ca In-reply-to: (message from Stefan Monnier on 04 Mar 2004 15:43:40 -0500) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:20269 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:20269 Stefan Monnier wrote: Too bad we can't do better, but thanks for double checking for me. I am sure we could save a few lines of duplicate code by rewriting and /or recombining auto-revert-active-p, auto-revert-buffer-p and auto-revert-handler, as well as maybe some other functions. I do not know whether that would be worth the trouble given that there appears to be plenty of other more user-visible unfinished business. > I need some way to tell not only dired, but other non-file > buffers as well, not to display the revert messages they usually do. Like which others? Well, I know none at the moment, but the non-file autoreverting applies to all non-file buffers with a revert-buffer function, so there is plenty of "opportunity" for further verbosity problems, given the generality. And why does dired display a message anyway? It seems just wrong to me, since the user knows he reverted the buffer if he did M-x revert-buffer (and indeed M-x revert-buffer in a file buffer does not output any message). It seems these messages should be output (when needed) by the code that calls revert-buffer-function. As does auto-revert, for example. I.e. I suggest to just throw out the dired messages. (As a side remark, reverting a dired buffer can be done with the `g' command.) I would personally favor getting rid of the messages, but I do not know whether other people would agree with us on this. It is possible that the message gives some reassurance to some users if the dired buffer did not visibly change. It is also possible that on very slow machines reverting a really huge dired buffer may take a non-trivial amount of time. But displaying an hourglass or so might convey the same "Emacs is busy" message anyway. Sincerely, Luc.