From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: save-buffer in tar-mode Date: Thu, 5 Feb 2004 11:17:44 +0900 (JST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200402050217.LAA03338@etlken.m17n.org> References: <20040204.135033.207583862.Takaaki.Ota@am.sony.com> <200402042336.IAA02815@etlken.m17n.org> <20040204.155331.190222248.Takaaki.Ota@am.sony.com> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: sea.gmane.org 1075947657 977 80.91.224.253 (5 Feb 2004 02:20:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 5 Feb 2004 02:20:57 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Thu Feb 05 03:20:52 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AoZ8N-0006HL-00 for ; Thu, 05 Feb 2004 03:20:51 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1AoZ8N-000180-00 for ; Thu, 05 Feb 2004 03:20:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AoZ6N-0000A1-9X for emacs-devel@quimby.gnus.org; Wed, 04 Feb 2004 21:18:47 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AoZ5y-000074-UD for emacs-devel@gnu.org; Wed, 04 Feb 2004 21:18:22 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AoZ5S-0008Dd-LC for emacs-devel@gnu.org; Wed, 04 Feb 2004 21:18:21 -0500 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AoZ5R-0008Bs-Vb for emacs-devel@gnu.org; Wed, 04 Feb 2004 21:17:50 -0500 Original-Received: from fs.m17n.org (fs.m17n.org [192.47.44.2]) by tsukuba.m17n.org (8.11.6p2/3.7W-20010518204228) with ESMTP id i152Hjh19337; Thu, 5 Feb 2004 11:17:45 +0900 (JST) (envelope-from handa@m17n.org) Original-Received: from etlken.m17n.org (etlken.m17n.org [192.47.44.125]) by fs.m17n.org (8.11.6p2/3.7W-20010823150639) with ESMTP id i152Hic00121; Thu, 5 Feb 2004 11:17:44 +0900 (JST) Original-Received: (from handa@localhost) by etlken.m17n.org (8.8.8+Sun/3.7W-2001040620) id LAA03338; Thu, 5 Feb 2004 11:17:44 +0900 (JST) Original-To: Takaaki.Ota@am.sony.com In-reply-to: <20040204.155331.190222248.Takaaki.Ota@am.sony.com> (message from Tak Ota on Wed, 04 Feb 2004 15:53:31 -0800 (PST)) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/21.3 (sparc-sun-solaris2.6) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:19725 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:19725 In article <20040204.155331.190222248.Takaaki.Ota@am.sony.com>, Tak Ota writes: >> Yes. tar-mode toggles enable-multibyte-characters on saving >> a file by set-buffer-multibyte and that function discards >> undo info. To fix it, we must record this toggling in >> buffer-undo-list. I proposed it long ago but was rejected >> at that time (I don't remember the reason, perhaps, just >> because it's not worth to work on it). > Thanks for the explanation. I think it should be fixed. Or, at least > this unwelcome side effect should be mentioned (warned) in the doc > string of set-buffer-multibyte where currently no mentioning about > this hidden trap. I added this sentence in the docstring. If the multibyte flag was really changed, undo information of the current buffer is cleared. --- Ken'ichi HANDA handa@m17n.org