From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Luc Teirlinck Newsgroups: gmane.emacs.bugs Subject: the ...-unload-hook convention doesn't work Date: Mon, 5 Jan 2004 12:24:51 -0600 (CST) Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Message-ID: <200401051824.i05IOpP07535@raven.dms.auburn.edu> NNTP-Posting-Host: deer.gmane.org X-Trace: sea.gmane.org 1073327183 29594 80.91.224.253 (5 Jan 2004 18:26:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 5 Jan 2004 18:26:23 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 05 19:26:18 2004 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1AdZQg-00025w-00 for ; Mon, 05 Jan 2004 19:26:18 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AdaNp-00058Y-7x for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Jan 2004 14:27:25 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1AdaNa-00050d-2g for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2004 14:27:10 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1AdaN1-0004hl-Ka for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2004 14:27:06 -0500 Original-Received: from [131.204.53.104] (helo=manatee.dms.auburn.edu) by monty-python.gnu.org with esmtp (Exim 4.24) id 1AdaN1-0004gC-BR for bug-gnu-emacs@gnu.org; Mon, 05 Jan 2004 14:26:35 -0500 Original-Received: from raven.dms.auburn.edu (raven.dms.auburn.edu [131.204.53.29]) by manatee.dms.auburn.edu (8.12.10/8.12.10) with ESMTP id i05IPKKk019539; Mon, 5 Jan 2004 12:25:21 -0600 (CST) Original-Received: (from teirllm@localhost) by raven.dms.auburn.edu (8.11.6+Sun/8.11.6) id i05IOpP07535; Mon, 5 Jan 2004 12:24:51 -0600 (CST) X-Authentication-Warning: raven.dms.auburn.edu: teirllm set sender to teirllm@dms.auburn.edu using -f Original-To: Dave Love X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Bug reports for GNU Emacs, the Swiss army knife of text editors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: main.gmane.org gmane.emacs.bugs:6487 X-Report-Spam: http://spam.gmane.org/gmane.emacs.bugs:6487 Dave Love wrote: I'm confused by this, since I'm sure it worked when I implemented it, but the installed code never seems to have been right since it's calling a function as if it were a hook list. It now is supposed to be a normal hook. From (elisp)Unloading: If `FEATURE-unload-hook' is defined, it is run as a normal hook before restoring the previous definitions, _instead of_ the usual hook-removing actions. But how could this have broken things? `run-hooks' is supposed to be able to handle a single function instead of a list, so there should be no problems with compatibility in as far as line 143 is concerned. Are there concrete examples of problems arising from either defining FEATURE-unload-hook as a function (even though, according to the Elisp manual, this is now considered obsolete) or defining it as a normal hook? Sincerely, Luc.