all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* emacs/lispref/Makefile.in: Minor fix for MS Win port
@ 2003-08-20  4:32 dhruva
  2003-08-22  9:12 ` Jason Rumney
  0 siblings, 1 reply; 5+ messages in thread
From: dhruva @ 2003-08-20  4:32 UTC (permalink / raw)


Hello,
 The Makefile.in in emacs/lispref has a small problem on MS Windows port.
 If it finds 'ln', it uses it and created a symbolic link to the original
 file BUT with a ".lnk" extension.

For ex:
 ln -s index.texi creates "index.texi.lnk"

I am sending a small patch to handle this in Makefile.in. Maybe crude,
but works! If you find this good enough, someone can install it. I have
no write access to CVS.

cmd I used (first file is from CVS, second file is modified file):
diff -p D:\tmp\cvs\emacs\emacs\lispref\Makefile.in Makefile.in

*** D:\tmp\cvs\emacs\emacs\lispref\Makefile.in  Wed Aug 13 19:45:11 2003
--- Makefile.in Wed Aug 20 09:51:04 2003
*************** index.texi:
*** 135,140 ****
--- 135,145 ----
        else \
          ln -s $(srcdir)/index.unperm index.texi || ln
          $(srcdir)/index.unperm index.texi || cp $(srcdir)/index.unperm
          index.texi; \
        fi
+       # For MS port of ln
+       if [ -f index.texi.lnk ]; \
+       then \
+         mv index.texi.lnk index.texi; \
+       fi

  install: elisp
        $(srcdir)/mkinstalldirs $(infodir)
-- 
Dhruva Krishnamurthy
Web: http://schemer.fateback.com/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* emacs/lispref/Makefile.in: Minor fix for MS Win port
@ 2003-08-20  8:05 dhruva
  0 siblings, 0 replies; 5+ messages in thread
From: dhruva @ 2003-08-20  8:05 UTC (permalink / raw)


Hello,
 I had sent a mail with this fix but my mail server went off. I am not
 sure whether the mail was sent. Incase it is duplicated, my apologies.

 In emacs/lispref/Makefile.in, a call to 'ln -s' is done on 'index.texi.
The MinGW/Win32 port of 'ln' creates a symbolic link with a '.lnk'
extension. Hence, "ln -s index.perm index.texi" results in a file
"index.texi.lnk" instead of "index.texi". This causes a build failure for
emacs/lispref. I have made a trivial modification.

with regards,
dhruva

[dky]diff -burN D:\tmp\cvs\emacs\emacs\lispref\Makefile.in Makefile.in
--- D:\tmp\cvs\emacs\emacs\lispref\Makefile.in  2003-08-13
19:45:11.000000000 +0530
+++ Makefile.in 2003-08-20 09:51:04.000000000 +0530
@@ -135,6 +135,11 @@
        else \
          ln -s $(srcdir)/index.unperm index.texi || ln
          $(srcdir)/index.unperm index.texi || cp $(srcdir)/index.unperm
          index.texi; \
        fi
+       # For MS port of ln
+       if [ -f index.texi.lnk ]; \
+       then \
+         mv index.texi.lnk index.texi; \
+       fi

 install: elisp
        $(srcdir)/mkinstalldirs $(infodir)
-- 
Dhruva Krishnamurthy
Web: http://schemer.fateback.com/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: emacs/lispref/Makefile.in: Minor fix for MS Win port
  2003-08-20  4:32 dhruva
@ 2003-08-22  9:12 ` Jason Rumney
  2003-08-22 11:48   ` dhruva
  2003-08-22 16:39   ` Peter 'Luna' Runestig
  0 siblings, 2 replies; 5+ messages in thread
From: Jason Rumney @ 2003-08-22  9:12 UTC (permalink / raw)
  Cc: Emacs Devel

dhruva wrote:
> Hello,
>  The Makefile.in in emacs/lispref has a small problem on MS Windows port.

The MS-Windows port does not use Makefile.in, I am surprised you got it 
working this far.

>  If it finds 'ln', it uses it and created a symbolic link to the original
>  file BUT with a ".lnk" extension.

That is correct for Cygwin I think. Does renaming the file actually 
work? Because Windows shortcuts (the equivalent of symbolic links) use 
the file extension to identify themselves, I think renaming it would 
prevent the shortcut from being recognised as such.

It would be better to write a Makefile-w32.in that takes care of the 
vast differences between Windows and Unix. Someone is already doing that 
for emacs/man, so that could be used as a template once it is ready.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: emacs/lispref/Makefile.in: Minor fix for MS Win port
  2003-08-22  9:12 ` Jason Rumney
@ 2003-08-22 11:48   ` dhruva
  2003-08-22 16:39   ` Peter 'Luna' Runestig
  1 sibling, 0 replies; 5+ messages in thread
From: dhruva @ 2003-08-22 11:48 UTC (permalink / raw)
  Cc: Emacs Devel

On Fri, 22 Aug 2003 10:12:46 +0100, "Jason Rumney" <jasonr@gnu.org> said:
> >  If it finds 'ln', it uses it and created a symbolic link to the original
> >  file BUT with a ".lnk" extension.
> 
> That is correct for Cygwin I think. Does renaming the file actually 
> work? Because Windows shortcuts (the equivalent of symbolic links) use 
> the file extension to identify themselves, I think renaming it would 
> prevent the shortcut from being recognised as such.

[dky]file --version
file-3.41
magic file from d:/MinGW32/share/magic

[dky]file index.texi
index.texi: ms-Windows shortcut

It does recognise the link after renaming as a shortcut even without the
'.lnk' extension.

with regards,
dhruva
-- 
Dhruva Krishnamurthy
Web: http://schemer.fateback.com/

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: emacs/lispref/Makefile.in: Minor fix for MS Win port
  2003-08-22  9:12 ` Jason Rumney
  2003-08-22 11:48   ` dhruva
@ 2003-08-22 16:39   ` Peter 'Luna' Runestig
  1 sibling, 0 replies; 5+ messages in thread
From: Peter 'Luna' Runestig @ 2003-08-22 16:39 UTC (permalink / raw)


On 2003-08-22 11:12, Jason Rumney wrote:
> It would be better to write a Makefile-w32.in that takes care of the 
> vast differences between Windows and Unix. Someone is already doing that 
> for emacs/man, so that could be used as a template once it is ready.

lispref/makefile.w32-in is in my "nmake info" patch.

-- 
Peter 'Luna' Runestig (fd. Altberg), Sweden <peter@runestig.com>
PGP Key ID: 0xD07BBE13
Fingerprint: 7B5C 1F48 2997 C061 DE4B  42EA CB99 A35C D07B BE13
AOL Instant Messenger Screen name: PRunestig
Yahoo! Messenger profile name: altberg

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2003-08-22 16:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-08-20  8:05 emacs/lispref/Makefile.in: Minor fix for MS Win port dhruva
  -- strict thread matches above, loose matches on Subject: below --
2003-08-20  4:32 dhruva
2003-08-22  9:12 ` Jason Rumney
2003-08-22 11:48   ` dhruva
2003-08-22 16:39   ` Peter 'Luna' Runestig

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.