From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.devel Subject: Re: Can't start Emacs on a monochrome display Date: Fri, 1 Aug 2003 15:34:07 +0900 (JST) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200308010634.PAA09329@etlken.m17n.org> References: <64563F69-C3E5-11D7-8BF5-00039363E640@swipnet.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Trace: main.gmane.org 1059719807 15136 80.91.224.249 (1 Aug 2003 06:36:47 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 1 Aug 2003 06:36:47 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, terjeros@phys.ntnu.no Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Aug 01 08:36:45 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19iTWv-0003vy-00 for ; Fri, 01 Aug 2003 08:36:45 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19iTZi-0002Kd-00 for ; Fri, 01 Aug 2003 08:39:39 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19iTVu-0007QD-OJ for emacs-devel@quimby.gnus.org; Fri, 01 Aug 2003 02:35:42 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19iTVL-0007Cv-94 for emacs-devel@gnu.org; Fri, 01 Aug 2003 02:35:07 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19iTUv-0006Pi-KC for emacs-devel@gnu.org; Fri, 01 Aug 2003 02:34:42 -0400 Original-Received: from [192.47.44.130] (helo=tsukuba.m17n.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19iTUZ-0005jY-E5; Fri, 01 Aug 2003 02:34:19 -0400 Original-Received: from fs.m17n.org (fs.m17n.org [192.47.44.2]) by tsukuba.m17n.org (8.11.6p2/3.7W-20010518204228) with ESMTP id h716Y8u17148; Fri, 1 Aug 2003 15:34:08 +0900 (JST) (envelope-from handa@m17n.org) Original-Received: from etlken.m17n.org (etlken.m17n.org [192.47.44.125]) by fs.m17n.org (8.11.6/3.7W-20010823150639) with ESMTP id h716Y8922781; Fri, 1 Aug 2003 15:34:08 +0900 (JST) Original-Received: (from handa@localhost) by etlken.m17n.org (8.8.8+Sun/3.7W-2001040620) id PAA09329; Fri, 1 Aug 2003 15:34:07 +0900 (JST) Original-To: jan.h.d@swipnet.se In-reply-to: <64563F69-C3E5-11D7-8BF5-00039363E640@swipnet.se> (jan.h.d@swipnet.se) User-Agent: SEMI/1.14.3 (Ushinoya) FLIM/1.14.2 (Yagi-Nishiguchi) APEL/10.2 Emacs/21.2.92 (sparc-sun-solaris2.6) MULE/5.0 (SAKAKI) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15768 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15768 In article <64563F69-C3E5-11D7-8BF5-00039363E640@swipnet.se>, "Jan D." writes: >> I asked Jan Djarv to look at this, since it concerns GTK, >> but he has not answered so I suspect he is on vacation. >> If someone else can figure it out, that would be good. > I got the impression Handa-san fixed this. Is that the case? Yes. I'll attach the relevant mail again. --- Ken'ichi HANDA handa@m17n.org ---------------------------------------------------------------------- Date: Thu, 31 Jul 2003 09:58:45 +0900 (JST) From: Kenichi Handa To: handa@m17n.org In-reply-to: <200307301317.WAA06628@etlken.m17n.org> (message from Kenichi Handa on Wed, 30 Jul 2003 22:17:50 +0900 (JST)) Cc: terjeros@phys.ntnu.no, emacs-devel@gnu.org Subject: Re: Can't start Emacs on a monochrome display X-Mailman-Copy: yes Sender: emacs-devel-bounces+handa=m17n.org@gnu.org In article <200307301317.WAA06628@etlken.m17n.org>, Kenichi Handa writes: > I tracked this problem down to this change: > 2003-07-13 Terje Rosten > * xterm.c (x_bitmap_icon,x_wm_set_icon_pixmap): Modify to add mask, > and use the Gtk+ function gtk_window_icon_from_file if available. > * xfns.c (x_bitmap_mask, x_create_bitmap_mask): New functions to > handle mask of bitmaps. > (x_allocate_bitmap_record, x_destroy_bitmap): Modify to handle the > mask property. > (xg_set_icon): New function, wrapper for gtk_window_icon_from_file. > * xterm.h (xg_set_icon): New function. > When I cancel this change, Emacs starts up correctly on a > monochrome display. I found what's wrong. On monochrome display, Emacs calls load_pixmap to make a stipple of a face. This function creates a pixmap without mask. But, x_destroy_bitmap unconditionaly tries to free a mask, thus xlib will free unallocated memory. So, I've installed these changes. 2003-07-31 Kenichi Handa * xterm.h (struct x_bitmap_record): New member have_mask. * xfns.c (x_create_bitmap_from_data): Initialize have_mask member to 0. (x_create_bitmap_from_file): Likewise. (x_destroy_bitmap): Check have_mask member before freeing a mask. (x_destroy_all_bitmaps): Likewise. (x_create_bitmap_mask): Set have_mask member to 1. --- Ken'ichi HANDA handa@m17n.org _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://mail.gnu.org/mailman/listinfo/emacs-devel