From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Markus Rost Newsgroups: gmane.emacs.devel Subject: Recent change to xfns.c breaks compilation Date: Mon, 14 Jul 2003 20:10:49 -0400 (EDT) Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200307150010.h6F0AnqV020175@hampton.math.ohio-state.edu> NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1058228178 4485 80.91.224.249 (15 Jul 2003 00:16:18 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Tue, 15 Jul 2003 00:16:18 +0000 (UTC) Cc: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Tue Jul 15 02:16:17 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19cDUP-0001AA-00 for ; Tue, 15 Jul 2003 02:16:17 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19cDht-0004Hd-00 for ; Tue, 15 Jul 2003 02:30:13 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19cDUB-00065i-Rn for emacs-devel@quimby.gnus.org; Mon, 14 Jul 2003 20:16:03 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19cDTB-0005Dc-9k for emacs-devel@gnu.org; Mon, 14 Jul 2003 20:15:01 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19cDSz-0004qZ-Cn for emacs-devel@gnu.org; Mon, 14 Jul 2003 20:14:50 -0400 Original-Received: from hermes.math.ohio-state.edu ([140.254.92.31]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19cDPE-00023k-FU for emacs-devel@gnu.org; Mon, 14 Jul 2003 20:10:56 -0400 Original-Received: from hampton.math.ohio-state.edu (hampton.math.ohio-state.edu [140.254.93.46]) by hermes.math.ohio-state.edu (8.12.9/8.12.9) with ESMTP id h6F0Aoso023861; Mon, 14 Jul 2003 20:10:50 -0400 Original-Received: from hampton.math.ohio-state.edu (localhost [127.0.0.1]) by hampton.math.ohio-state.edu (8.12.9/8.12.9) with ESMTP id h6F0AoZH020178; Mon, 14 Jul 2003 20:10:50 -0400 (EDT) Original-Received: (from rost@localhost) by hampton.math.ohio-state.edu (8.12.9/8.12.8/Submit) id h6F0AnqV020175; Mon, 14 Jul 2003 20:10:49 -0400 (EDT) Original-To: storm@cua.dk X-Mailer: GNU Emacs 21.3 Emacs-W3/4.0pre.46 X-Home-Page: http://www.math.ohio-state.edu/~rost X-Url-From: http://mail.gnu.org/archive/html/emacs-devel/2003-07/index.html In-Reply-To: 5xznjjcj8h.fsf@kfs2.cua.dk X-RAVMilter-Version: 8.4.2(snapshot 20021217) (hermes) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Emacs development discussions. List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15610 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15610 This change: 2003-07-12 Richard M. Stallman * xfns.c: Include libpng/png.h instead of png.h. causes problems on my GNU/Linux system (redhat 6.2) where png.h is in /usr/include. What is the rationale for that change? Since configure only checks for the presence of png.h (and not libpng/png.h), I think we need to check for both and condition the #include with HAVE_PNG_H and HAVE_LIBPNG_PNG_H. It still breaks compilation for me, on gnu/linux and solaris. Moreover autoconf does not work well after the recent change 2003-07-12 Richard M. Stallman * configure.in [netbsd systems]: Define HAVE_CRTIN properly. Here are some lines from the shell: gcc -c -D_BSD_SOURCE -Demacs -DHAVE_CONFIG_H -DUSE_LUCID -I. -I/home/rost/cvs-gnu-linux1/emacs/src -D_BSD_SOURCE -I/usr/X11R6/include -g xfns.c xfns.c:7568:24: libpng/png.h: No such file or directory make[1]: *** [xfns.o] Error 1 make[1]: Leaving directory `/home/rost/cvs-gnu-linux1/emacs/src' make: *** [bootstrap] Error 2 euler:~/cvs-gnu-linux1/emacs> autoconf configure.in:50: error: possibly undefined macro: AC_DEFINE If this token and others are legitimate, please use m4_pattern_allow. See the Autoconf documentation. euler:~/cvs-gnu-linux1/emacs> autoconf --version autoconf (GNU Autoconf) 2.57 euler:~/cvs-gnu-linux1/emacs> configure checking build system type... i686-pc-linux-gnu checking host system type... i686-pc-linux-gnu ./configure: line 1666: syntax error near unexpected token `AC_DEFINE(HAVE_CRTIN)' ./configure: line 1666: ` AC_DEFINE(HAVE_CRTIN)'