all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Markus Rost <rost@math.ohio-state.edu>
Cc: emacs-devel@gnu.org
Subject: Recent change to xfns.c breaks compilation
Date: Mon, 14 Jul 2003 20:10:49 -0400 (EDT)	[thread overview]
Message-ID: <200307150010.h6F0AnqV020175@hampton.math.ohio-state.edu> (raw)
In-Reply-To: 5xznjjcj8h.fsf@kfs2.cua.dk


   This change:

   2003-07-12  Richard M. Stallman  <rms@bogus.example.com>

	   * xfns.c: Include libpng/png.h instead of png.h.

   causes problems on my GNU/Linux system (redhat 6.2) where png.h is in
   /usr/include.

   What is the rationale for that change?


   Since configure only checks for the presence of png.h (and not
   libpng/png.h), I think we need to check for both and condition the
   #include with HAVE_PNG_H and HAVE_LIBPNG_PNG_H.

It still breaks compilation for me, on gnu/linux and solaris.
Moreover autoconf does not work well after the recent change

2003-07-12  Richard M. Stallman  <rms@gnu.org>

	* configure.in [netbsd systems]: Define HAVE_CRTIN properly.

Here are some lines from the shell:

gcc -c -D_BSD_SOURCE   -Demacs -DHAVE_CONFIG_H -DUSE_LUCID  -I. -I/home/rost/cvs-gnu-linux1/emacs/src -D_BSD_SOURCE -I/usr/X11R6/include -g xfns.c
xfns.c:7568:24: libpng/png.h: No such file or directory
make[1]: *** [xfns.o] Error 1
make[1]: Leaving directory `/home/rost/cvs-gnu-linux1/emacs/src'
make: *** [bootstrap] Error 2

euler:~/cvs-gnu-linux1/emacs> autoconf
configure.in:50: error: possibly undefined macro: AC_DEFINE
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.

euler:~/cvs-gnu-linux1/emacs> autoconf --version
autoconf (GNU Autoconf) 2.57

euler:~/cvs-gnu-linux1/emacs> configure
checking build system type... i686-pc-linux-gnu
checking host system type... i686-pc-linux-gnu
./configure: line 1666: syntax error near unexpected token `AC_DEFINE(HAVE_CRTIN)'
./configure: line 1666: `      AC_DEFINE(HAVE_CRTIN)'

             reply	other threads:[~2003-07-15  0:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-15  0:10 Markus Rost [this message]
2003-07-16 10:31 ` Recent change to xfns.c breaks compilation Richard Stallman
2003-07-16 11:56   ` Andreas Schwab
2003-07-17 10:10     ` Richard Stallman
2003-07-17 10:19       ` David Kastrup
2003-07-17 11:15       ` Andreas Schwab
2003-07-17 14:38       ` Markus Rost
  -- strict thread matches above, loose matches on Subject: below --
2003-07-13  1:23 Kim F. Storm
     [not found] ` <E19bkkG-0005iJ-Ak@fencepost.gnu.org>
     [not found]   ` <5xwuekaekd.fsf@kfs2.cua.dk>
2003-07-15 11:02     ` Richard Stallman
2003-07-20 23:06     ` Richard Stallman
2003-07-22 19:12       ` Kai Großjohann
2003-07-23 23:03         ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307150010.h6F0AnqV020175@hampton.math.ohio-state.edu \
    --to=rost@math.ohio-state.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.