From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: "Stefan Monnier" Newsgroups: gmane.emacs.devel Subject: Re: install.el Date: Sun, 15 Jun 2003 12:27:54 -0400 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200306151627.h5FGRshP032439@rum.cs.yale.edu> References: <200306142045.h5EKjoQC022841@rum.cs.yale.edu> <2110-Sun15Jun2003191234+0300-eliz@elta.co.il> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1055694557 29600 80.91.224.249 (15 Jun 2003 16:29:17 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Sun, 15 Jun 2003 16:29:17 +0000 (UTC) Cc: monnier+gnu/emacs@rum.cs.yale.edu Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Sun Jun 15 18:29:12 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 19RaMS-0007dj-00 for ; Sun, 15 Jun 2003 18:28:08 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 19RajS-0006yC-00 for ; Sun, 15 Jun 2003 18:51:54 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.20) id 19RaNb-0000RJ-Qr for emacs-devel@quimby.gnus.org; Sun, 15 Jun 2003 12:29:19 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20) id 19RaN4-00004w-6O for emacs-devel@gnu.org; Sun, 15 Jun 2003 12:28:46 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20) id 19RaMo-0007n4-2L for emacs-devel@gnu.org; Sun, 15 Jun 2003 12:28:30 -0400 Original-Received: from rum.cs.yale.edu ([128.36.229.169]) by monty-python.gnu.org with esmtp (Exim 4.20) id 19RaMG-0006bx-Qw for emacs-devel@gnu.org; Sun, 15 Jun 2003 12:27:56 -0400 Original-Received: from rum.cs.yale.edu (localhost [127.0.0.1]) by rum.cs.yale.edu (8.12.8/8.12.8) with ESMTP id h5FGRs0i032441; Sun, 15 Jun 2003 12:27:54 -0400 Original-Received: (from monnier@localhost) by rum.cs.yale.edu (8.12.8/8.12.8/Submit) id h5FGRshP032439; Sun, 15 Jun 2003 12:27:54 -0400 X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4 Original-To: "Eli Zaretskii" Original-cc: emacs-devel@gnu.org X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:15113 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:15113 > > From: "Stefan Monnier" > > Date: Sat, 14 Jun 2003 16:45:50 -0400 > > > > So I started to write install.el which is a package that offer the function > > `install-file'. It takes a file (a ginel elisp file or a tarball) and > > somehow installs it at a useful place, compiles the elisp file(s) > > and activates the package by adding some relevant commands in your .emacs. > > > > Its current status is closer to proof-of-concept than to fool-proof, > > but I'd like to install it in CVS. > > Please allow me a few minor comments: I'd love to hear comments about the "big picture" as well, but coding nitpicks are very welcome. > > (defcustom install-home-file (or user-init-file "~/.emacs") > ^^^^^^^^^^ > This should be ``(convert-standard-filename "~/.emacs")'', for those > platforms where .emacs is an invalid file name. Actually, I'm not even sure if it shouldn't just be user-init-file. > > (or (car (install-glob (concat "**/" install-autoload-file))) > > (car (install-glob "**/auto-autoloads.el")) > > (car (install-glob "**/*-site.el"))))) > > I think these (and a few other similar) expansions might fail if file > names are truncated to 8+3. That is, > > (install-glob "auto-autoloads.el") > > will not find "auto-aut.el", right? Should we worry about this case ? `auto-autoloads.el' is the name of a file used by XEmacs packages. I think the problem is more serious for install-autoload-file which is 9 letters long with no extension. We may need to use some other name. > > (defconst install-info-dir "-*- Text -*-\n\n\ > > File: dir Node: Top This is the top of the INFO tree\ > > \n\n* Menu:\n\n" > > "Text content of a barebones empty `info/dir' file.") > > I think this text should follow the recommendations in the Texinfo > package docs. Feel free to send a patch. I didn't look at the docs, but just took a sample file and trimmed it down. Stefan