From mboxrd@z Thu Jan  1 00:00:00 1970
Path: main.gmane.org!not-for-mail
From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Newsgroups: gmane.emacs.devel
Subject: Re: uniquify & advice
Date: Fri, 06 Jun 2003 11:31:15 -0400
Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Message-ID: <200306061531.h56FVFBl006394@rum.cs.yale.edu>
References: <buovfvj263o.fsf@mcspd15.ucom.lsi.nec.co.jp>
NNTP-Posting-Host: main.gmane.org
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Trace: main.gmane.org 1054914342 15568 80.91.224.249 (6 Jun 2003 15:45:42 GMT)
X-Complaints-To: usenet@main.gmane.org
NNTP-Posting-Date: Fri, 6 Jun 2003 15:45:42 +0000 (UTC)
Cc: emacs-devel@gnu.org
Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jun 06 17:45:39 2003
Return-path: <emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org>
Original-Received: from quimby.gnus.org ([80.91.224.244])
	by main.gmane.org with esmtp (Exim 3.35 #1 (Debian))
	id 19OJP4-00041J-00
	for <emacs-devel@main.gmane.org>; Fri, 06 Jun 2003 17:45:18 +0200
Original-Received: from monty-python.gnu.org ([199.232.76.173])
	by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian))
	id 19OJhg-0001cn-00
	for <emacs-devel@quimby.gnus.org>; Fri, 06 Jun 2003 18:04:32 +0200
Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org)
	by monty-python.gnu.org with esmtp (Exim 4.20)
	id 19OJQN-0003UZ-3s
	for emacs-devel@quimby.gnus.org; Fri, 06 Jun 2003 11:46:39 -0400
Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.20)
	id 19OJOm-00030K-25
	for emacs-devel@gnu.org; Fri, 06 Jun 2003 11:45:00 -0400
Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.20)
	id 19OJMt-00021S-PN
	for emacs-devel@gnu.org; Fri, 06 Jun 2003 11:43:04 -0400
Original-Received: from rum.cs.yale.edu ([128.36.229.169])
	by monty-python.gnu.org with esmtp (Exim 4.20)
	id 19OJBV-0006oF-1D
	for emacs-devel@gnu.org; Fri, 06 Jun 2003 11:31:17 -0400
Original-Received: from rum.cs.yale.edu (localhost [127.0.0.1])
	by rum.cs.yale.edu (8.12.8/8.12.8) with ESMTP id h56FVG0i006396;
	Fri, 6 Jun 2003 11:31:16 -0400
Original-Received: (from monnier@localhost)
	by rum.cs.yale.edu (8.12.8/8.12.8/Submit) id h56FVFBl006394;
	Fri, 6 Jun 2003 11:31:15 -0400
X-Mailer: exmh version 2.4 06/23/2000 with nmh-1.0.4
Original-To: Miles Bader <miles@lsi.nec.co.jp>
X-BeenThere: emacs-devel@gnu.org
X-Mailman-Version: 2.1b5
Precedence: list
List-Id: Emacs development discussions. <emacs-devel.gnu.org>
List-Help: <mailto:emacs-devel-request@gnu.org?subject=help>
List-Post: <mailto:emacs-devel@gnu.org>
List-Subscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=subscribe>
List-Archive: <http://mail.gnu.org/pipermail/emacs-devel>
List-Unsubscribe: <http://mail.gnu.org/mailman/listinfo/emacs-devel>,
	<mailto:emacs-devel-request@gnu.org?subject=unsubscribe>
Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org
Xref: main.gmane.org gmane.emacs.devel:14833
X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:14833

> uniquify.el still uses `defadvice' for some of its functionality;
> shouldn't we just add appropriate code (or hooks) to the underlying
> functions instead?
> 
> Here's what it uses:
> 
>    (defadvice rename-buffer (after rename-buffer-uniquify activate)
>      "Uniquify buffer names with parts of directory name."
> 
>    (defadvice create-file-buffer (after create-file-buffer-uniquify activate)
>      "Uniquify buffer names with parts of directory name."

Yes.  I remember looking at it in the past and ended up not doing it
because I couldn't come up with a good hook.


	Stefan