From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: bug in forward-visible-line: Patch
Date: Thu, 22 May 2003 08:56:43 -0400 [thread overview]
Message-ID: <200305221256.h4MCuhjv003998@rum.cs.yale.edu> (raw)
In-Reply-To: 200305220443.h4M4h4w10124@eel.dms.auburn.edu
> ! (if (if (eq buffer-invisibility-spec t)
> ! prop
> ! (or (memq prop buffer-invisibility-spec)
> ! (assq prop buffer-invisibility-spec)))
BTW, how about a `invisible-p' function that does above ?
Especially since the above is wrong (the assq might match a cons
cell like (foo . nil) which says that it's *not* invisible).
Also while I'm talking about the invisible property.
A lot of code uses t as an invisible value that is assumed to
always be invisible and nil for the opposite. A recent change
makes buffer-invisibility-spec always contain t so that t should
indeed always be invisible, but I think a better change is to make
the invisibility check something like
(cond
((eq buffer-invisibility-spec t) val)
((null val) 'visible)
((eq val t) 'invisible)
(t (or (memq prop buffer-invisibility-spec)
(cdr (assq prop buffer-invisibility-spec)))))
where the change is that nil and t are special values that do
not depend on buffer-invisibility-spec.
Stefan
next prev parent reply other threads:[~2003-05-22 12:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-22 4:43 bug in forward-visible-line: Patch Luc Teirlinck
2003-05-22 12:56 ` Stefan Monnier [this message]
2003-05-22 17:46 ` Luc Teirlinck
2003-05-22 21:40 ` Luc Teirlinck
2003-05-22 21:51 ` Stefan Monnier
2003-05-22 22:03 ` Luc Teirlinck
2003-05-22 22:23 ` Luc Teirlinck
2003-05-22 23:38 ` Luc Teirlinck
2003-05-23 0:03 ` Luc Teirlinck
2003-05-22 22:27 ` David Kastrup
2003-05-23 8:54 ` Miles Bader
2003-05-23 16:18 ` Luc Teirlinck
2003-05-24 23:19 ` Richard Stallman
2003-05-23 22:48 ` Richard Stallman
2003-05-23 15:50 ` Luc Teirlinck
2003-05-22 21:46 ` Luc Teirlinck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200305221256.h4MCuhjv003998@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.