recentf suggestion

recentf suggestion

[Tak Ota]

I encountered a minor problem while using recentf.  The function
recentf-cleanup checks the file's accessibility first then tests if
the file should be excluded.  I exclude network files since they many
not be available later time but the current testing order ruins this
arrangement.  It anyway goes out to the network and blocks emacs until
the connecting attempt to an unreachable host times out.  How about
swapping the two tests?

-Tak

$ diff -c ../../../pub/emacs/pure/emacs-21.3.50/lisp/recentf.el recentf.el
*** ../../../pub/emacs/pure/emacs-21.3.50/lisp/recentf.el	Sun Apr 27 07:22:17 2003
--- recentf.el	Thu May  1 17:49:06 2003
***************
*** 1127,1133 ****
    (message "Cleaning up the recentf list...")
    (let (newlist)
      (dolist (f recentf-list)
!       (if (and (file-readable-p f) (recentf-include-p f))
            (push f newlist)
          (message "File %s removed from the recentf list" f)))
      (setq recentf-list (nreverse newlist))
--- 1127,1133 ----
    (message "Cleaning up the recentf list...")
    (let (newlist)
      (dolist (f recentf-list)
!       (if (and (recentf-include-p f) (file-readable-p f))
            (push f newlist)
          (message "File %s removed from the recentf list" f)))
      (setq recentf-list (nreverse newlist))

Re: recentf suggestion

[David Ponce]

Hi Tak,
> I encountered a minor problem while using recentf.  The function
> recentf-cleanup checks the file's accessibility first then tests if
> the file should be excluded.  I exclude network files since they many
> not be available later time but the current testing order ruins this
> arrangement.  It anyway goes out to the network and blocks emacs until
> the connecting attempt to an unreachable host times out.  How about
> swapping the two tests?

That's a good suggestion.  Please could someone check this patch in?

Thanks!
David