From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Bill Wohler Newsgroups: gmane.emacs.devel Subject: Re: Incorporating patches into GNU Emacs Date: Fri, 18 Apr 2003 09:11:17 -0700 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: <200304181611.h3IGBHUY008404@gbr.newt.com> NNTP-Posting-Host: main.gmane.org X-Trace: main.gmane.org 1050682713 1171 80.91.224.249 (18 Apr 2003 16:18:33 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Fri, 18 Apr 2003 16:18:33 +0000 (UTC) Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Apr 18 18:18:31 2003 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 196YZK-0000Ig-00 for ; Fri, 18 Apr 2003 18:18:30 +0200 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 196Yci-0005j0-00 for ; Fri, 18 Apr 2003 18:22:00 +0200 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 196YZs-0002r9-00 for emacs-devel@quimby.gnus.org; Fri, 18 Apr 2003 12:19:04 -0400 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 196YZ8-0002b5-00 for emacs-devel@gnu.org; Fri, 18 Apr 2003 12:18:18 -0400 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 196YW6-0000TA-00 for emacs-devel@gnu.org; Fri, 18 Apr 2003 12:15:12 -0400 Original-Received: from adsl-63-205-67-50.dsl.snfc21.pacbell.net ([63.205.67.50] helo=gbr.newt.com) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 196YSN-0005wX-00 for emacs-devel@gnu.org; Fri, 18 Apr 2003 12:11:19 -0400 Original-Received: from newt.com (wohler@localhost [127.0.0.1]) by gbr.newt.com (8.12.8/8.12.8/Debian-2) with ESMTP id h3IGBHUY008404 for ; Fri, 18 Apr 2003 09:11:18 -0700 Original-To: emacs-devel@gnu.org X-Mailer: MH-E 7.2+cvs; nmh 1.0.4+dev; GNU Emacs 21.2.1 X-Face: "5k'?Iz]8K@!MNcM~N?&Uw3~UkuQ+b^{)ecyVaJlgKxZsT76xpl+W$/c9RtY/Y6sz>Gg)!b>}74-9nWJC&ajPue}*aD@s"?sQ6;P]M|q1^@We1p_T(A.u[0>+]Ez|;`.biir|K7$UQS=8rxc)`O^~DJs-a7p7XENI_7c]
  • List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:13289 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:13289 Here's a specific example from bug.gnu.emacs: A patch from an Emacs user who hasn't signed papers. Are you telling me that a) you'll ignore it, or b) you'll really go through all the trouble of getting Gustav to sign papers in order to use it? p.s. Is there an Emacs Maintainers Manual where all this stuff is neatly summarized? From: Gustav Hållberg Subject: vc-annotate does not copy truncate-lines from the origin buffer If you have set truncate-lines in a buffer, it would make a lot of sense for the vc-annotate command to use that setting in the newly created annotation buffer too (the same could probably be said for other variables too, but this is the one I was being annoyed by right now). Suggested patch attached. - Gustav Newsgroups: gnu.emacs.bug Date: 17 Apr 2003 11:34:18 +0200 X-Boundary: _______________________________________________________________________________ [2. text/x-patch; vc-annotate-truncate-lines.patch] --- /disk1/sources/emacs-21.3/lisp/vc.el Mon Jan 20 12:03:30 2003 +++ vc.el Thu Apr 17 11:27:14 2003 @@ -2941,6 +2941,7 @@ (vc-ensure-vc-buffer) (let* ((temp-buffer-name (concat "*Annotate " (buffer-name) "*")) (temp-buffer-show-function 'vc-annotate-display) + (temp-truncate-lines truncate-lines) (rev (vc-workfile-version (buffer-file-name))) (vc-annotate-version (if prefix (read-string @@ -2953,7 +2954,7 @@ nil nil "1.0")) 1.0)) (vc-annotate-backend (vc-backend (buffer-file-name)))) - (message "Annotating...") + (message "Annotating... %s" temp-truncate-lines) (if (not (vc-find-backend-function vc-annotate-backend 'annotate-command)) (error "Sorry, annotating is not implemented for %s" vc-annotate-backend)) @@ -2962,6 +2963,9 @@ (file-name-nondirectory (buffer-file-name)) (get-buffer temp-buffer-name) vc-annotate-version)) + (save-excursion + (set-buffer temp-buffer-name) + (setq truncate-lines temp-truncate-lines)) ;; Don't use the temp-buffer-name until the buffer is created ;; (only after `with-output-to-temp-buffer'.) (setq vc-annotate-buffers -- Bill Wohler http://www.newt.com/wohler/ GnuPG ID:610BD9AD Maintainer of comp.mail.mh FAQ and MH-E. Vote Libertarian! If you're passed on the right, you're in the wrong lane.