From: "Stefan Monnier" <monnier+gnu/emacs@rum.cs.yale.edu>
Subject: sit-for incompatibility
Date: Mon, 07 Apr 2003 14:50:38 -0400 [thread overview]
Message-ID: <200304071850.h37Iocnr025254@rum.cs.yale.edu> (raw)
Emacs and XEmacs' sit-for functions are incompatible in that Emacs
uses (sit-for SECONDS MILLISECONDS NODISP) whereas XEmacs uses
(sit-for SECONDS NODISP).
I suggest that we change Emacs' function to recognize that if
NODISP is nil and MILLISECONDS is not a number, than we should
behave as XEmacs does.
The patch below does that, although I think the docstring part
of the patch is unsatisfactory.
Stefan
--- dispnew.c.~1.314.~ Sat Mar 22 15:52:58 2003
+++ dispnew.c Mon Apr 7 14:45:53 2003
@@ -6263,12 +6263,21 @@
Optional third arg NODISP non-nil means don't redisplay, just wait for input.
Redisplay is preempted as always if input arrives, and does not happen
if input is available before it starts.
-Value is t if waited the full time with no input arriving. */)
+Value is t if waited the full time with no input arriving.
+
+If MILLISECONDS is not a number and NODISP is nil, it is assumed that
+the second argument is actually meant to be used for NODISP. */)
(seconds, milliseconds, nodisp)
Lisp_Object seconds, milliseconds, nodisp;
{
int sec, usec;
+ if (NILP (nodisp) && !NUMBERP (milliseconds))
+ { /* New style. */
+ nodisp = milliseconds;
+ milliseconds = Qnil;
+ }
+
if (NILP (milliseconds))
XSETINT (milliseconds, 0);
else
next reply other threads:[~2003-04-07 18:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 18:50 Stefan Monnier [this message]
2003-04-08 6:45 ` sit-for incompatibility Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200304071850.h37Iocnr025254@rum.cs.yale.edu \
--to=monnier+gnu/emacs@rum.cs.yale.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.