* bad interaction with C-x RET c and vc-cvs-registered
@ 2003-03-28 2:30 Kenichi Handa
0 siblings, 0 replies; 4+ messages in thread
From: Kenichi Handa @ 2003-03-28 2:30 UTC (permalink / raw)
I've just found this problem.
If we have a UTF-16 file in a CVS working directory, and
visit that file by C-x RET c utf-16 C-x C-f FILENAME, vc-cvs
doesn't detect that file is registered in CVS.
This is because the function vc-cvs-registered is called
while coding-system-for-read being bound to utf-16, so it
reads the file "CVS/Entries" with utf-16 coding system (via
vc-insert-file), thus can't find FILENAME in that file.
I think CVS/Entries should be read with
file-name-coding-system (or
default-file-name-coding-system). But, I'm not sure in
which function(s) we should do this something like this.
(let ((coding-system-for-read (or file-name-coding-system
default-file-name-coding-system)))
...)
For instance, this paticular problem is fixed by doing that
in vc-cvs-registered (vc-cvs.el). But, the other
function(s) also read CVS/Entries. It may be better to do
that in vc-insert-file (vc-hooks.el).
Could someone who knows those codes well work on it?
---
Ken'ichi HANDA
handa@m17n.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bad interaction with C-x RET c and vc-cvs-registered
[not found] <E18zLDm-0001u0-00@fencepost.gnu.org>
@ 2003-03-31 8:58 ` Andre Spiegel
2003-03-31 12:11 ` Kenichi Handa
2003-04-06 12:36 ` Andre Spiegel
1 sibling, 1 reply; 4+ messages in thread
From: Andre Spiegel @ 2003-03-31 8:58 UTC (permalink / raw)
Cc: handa
> Date: Fri, 28 Mar 2003 11:30:05 +0900 (JST)
> From: Kenichi Handa <handa@m17n.org>
[...]
> This is because the function vc-cvs-registered is called
> while coding-system-for-read being bound to utf-16, so it
> reads the file "CVS/Entries" with utf-16 coding system (via
> vc-insert-file), thus can't find FILENAME in that file.
I'm working on it. Thanks for pointing it out.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bad interaction with C-x RET c and vc-cvs-registered
2003-03-31 8:58 ` bad interaction with C-x RET c and vc-cvs-registered Andre Spiegel
@ 2003-03-31 12:11 ` Kenichi Handa
0 siblings, 0 replies; 4+ messages in thread
From: Kenichi Handa @ 2003-03-31 12:11 UTC (permalink / raw)
Cc: emacs-devel
In article <1049101101.531.2.camel@localhost>, Andre Spiegel <spiegel@gnu.org> writes:
>> Date: Fri, 28 Mar 2003 11:30:05 +0900 (JST)
>> From: Kenichi Handa <handa@m17n.org>
> [...]
>> This is because the function vc-cvs-registered is called
>> while coding-system-for-read being bound to utf-16, so it
>> reads the file "CVS/Entries" with utf-16 coding system (via
>> vc-insert-file), thus can't find FILENAME in that file.
> I'm working on it. Thanks for pointing it out.
Thank you for taking on it.
---
Ken'ichi HANDA
handa@m17n.org
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: bad interaction with C-x RET c and vc-cvs-registered
[not found] <E18zLDm-0001u0-00@fencepost.gnu.org>
2003-03-31 8:58 ` bad interaction with C-x RET c and vc-cvs-registered Andre Spiegel
@ 2003-04-06 12:36 ` Andre Spiegel
1 sibling, 0 replies; 4+ messages in thread
From: Andre Spiegel @ 2003-04-06 12:36 UTC (permalink / raw)
Cc: handa
> Date: Fri, 28 Mar 2003 11:30:05 +0900 (JST)
> From: Kenichi Handa <handa@m17n.org>
> If we have a UTF-16 file in a CVS working directory, and
> visit that file by C-x RET c utf-16 C-x C-f FILENAME, vc-cvs
> doesn't detect that file is registered in CVS.
>
> This is because the function vc-cvs-registered is called
> while coding-system-for-read being bound to utf-16, so it
> reads the file "CVS/Entries" with utf-16 coding system (via
> vc-insert-file), thus can't find FILENAME in that file.
I've fixed this with a new local function in vc-cvs.el,
vc-cvs-get-entries, which uses the right coding system. Other backends
(may) have different coding systems in their control files, so making
the change in vc-insert-file, as you wondered, would not be a possible
solution.
Thanks for pointing this out.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2003-04-06 12:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E18zLDm-0001u0-00@fencepost.gnu.org>
2003-03-31 8:58 ` bad interaction with C-x RET c and vc-cvs-registered Andre Spiegel
2003-03-31 12:11 ` Kenichi Handa
2003-04-06 12:36 ` Andre Spiegel
2003-03-28 2:30 Kenichi Handa
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.