* strange change in store_symval_forwarding (data.c)
@ 2003-03-26 2:53 Kenichi Handa
2003-03-26 14:41 ` Andreas Schwab
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Kenichi Handa @ 2003-03-26 2:53 UTC (permalink / raw)
Currently, store_symval_forwarding has this code:
case Lisp_Misc_Buffer_Objfwd:
{
int offset = XBUFFER_OBJFWD (valcontents)->offset;
Lisp_Object type;
if (! NILP (type) && ! NILP (newval)
&& XTYPE (newval) != XINT (type))
buffer_slot_type_mismatch (offset);
Please note that the local variable `type' is used without
being initialized.
Previously, the code has this initilization part:
Lisp_Object type;
type = PER_BUFFER_TYPE (offset);
if (XINT (type) == -1)
error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
ChangeLog doesn't say anything about this change, but it
seems that it was done when this change was installed.
2003-03-13 Andreas Schwab <schwab@suse.de>
[...]
* data.c (long_to_cons): Fix type of top.
Andreas, do you know somthing about it?
---
Ken'ichi HANDA
handa@m17n.org
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: strange change in store_symval_forwarding (data.c)
2003-03-26 2:53 strange change in store_symval_forwarding (data.c) Kenichi Handa
@ 2003-03-26 14:41 ` Andreas Schwab
2003-03-26 14:51 ` Andreas Schwab
2003-03-26 15:38 ` Stefan Monnier
2 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2003-03-26 14:41 UTC (permalink / raw)
Cc: emacs-devel
Kenichi Handa <handa@m17n.org> writes:
|> Currently, store_symval_forwarding has this code:
|>
|> case Lisp_Misc_Buffer_Objfwd:
|> {
|> int offset = XBUFFER_OBJFWD (valcontents)->offset;
|> Lisp_Object type;
|>
|> if (! NILP (type) && ! NILP (newval)
|> && XTYPE (newval) != XINT (type))
|> buffer_slot_type_mismatch (offset);
|>
|> Please note that the local variable `type' is used without
|> being initialized.
|>
|> Previously, the code has this initilization part:
|>
|> Lisp_Object type;
|>
|> type = PER_BUFFER_TYPE (offset);
|> if (XINT (type) == -1)
|> error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
|>
|> ChangeLog doesn't say anything about this change, but it
|> seems that it was done when this change was installed.
|>
|> 2003-03-13 Andreas Schwab <schwab@suse.de>
|> [...]
|> * data.c (long_to_cons): Fix type of top.
|>
|> Andreas, do you know somthing about it?
This code was already like this in revision 1.219, ie. before my change.
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: strange change in store_symval_forwarding (data.c)
2003-03-26 2:53 strange change in store_symval_forwarding (data.c) Kenichi Handa
2003-03-26 14:41 ` Andreas Schwab
@ 2003-03-26 14:51 ` Andreas Schwab
2003-03-27 0:58 ` Kenichi Handa
2003-03-26 15:38 ` Stefan Monnier
2 siblings, 1 reply; 5+ messages in thread
From: Andreas Schwab @ 2003-03-26 14:51 UTC (permalink / raw)
Cc: emacs-devel
Kenichi Handa <handa@m17n.org> writes:
|> Currently, store_symval_forwarding has this code:
|>
|> case Lisp_Misc_Buffer_Objfwd:
|> {
|> int offset = XBUFFER_OBJFWD (valcontents)->offset;
|> Lisp_Object type;
|>
|> if (! NILP (type) && ! NILP (newval)
|> && XTYPE (newval) != XINT (type))
|> buffer_slot_type_mismatch (offset);
|>
|> Please note that the local variable `type' is used without
|> being initialized.
|>
|> Previously, the code has this initilization part:
|>
|> Lisp_Object type;
|>
|> type = PER_BUFFER_TYPE (offset);
|> if (XINT (type) == -1)
|> error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
|>
|> ChangeLog doesn't say anything about this change, but it
|> seems that it was done when this change was installed.
This was changed as part of Stefan's checkin (revision 1.221), which does
not have a ChangeLog entry (yet).
Andreas.
--
Andreas Schwab, SuSE Labs, schwab@suse.de
SuSE Linux AG, Deutschherrnstr. 15-19, D-90429 Nürnberg
Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: strange change in store_symval_forwarding (data.c)
2003-03-26 2:53 strange change in store_symval_forwarding (data.c) Kenichi Handa
2003-03-26 14:41 ` Andreas Schwab
2003-03-26 14:51 ` Andreas Schwab
@ 2003-03-26 15:38 ` Stefan Monnier
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Monnier @ 2003-03-26 15:38 UTC (permalink / raw)
Cc: emacs-devel
> Previously, the code has this initilization part:
>
> Lisp_Object type;
>
> type = PER_BUFFER_TYPE (offset);
> if (XINT (type) == -1)
> error ("Variable %s is read-only", SDATA (SYMBOL_NAME (symbol)));
Sorry, my bad. I meant to only delete the last two lines.
Should be fixed now,
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2003-03-27 0:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-26 2:53 strange change in store_symval_forwarding (data.c) Kenichi Handa
2003-03-26 14:41 ` Andreas Schwab
2003-03-26 14:51 ` Andreas Schwab
2003-03-27 0:58 ` Kenichi Handa
2003-03-26 15:38 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.