From: "Stefan Monnier" <monnier+gnu/emacs/pretest@rum.cs.yale.edu>
Cc: emacs-devel@gnu.org
Subject: Re: [calendar] Holidays menu doesn't go away
Date: Sat, 22 Mar 2003 17:30:41 -0500 [thread overview]
Message-ID: <200303222230.h2MMUf8B032565@rum.cs.yale.edu> (raw)
In-Reply-To: 8765qb1224.fsf@indigo.shootybangbang.com
> > The logentry explains why:
> >
> > * emacs-lisp/easymenu.el (easy-menu-name-match): Catch any error
> > that member-ignore-case might signal.
> > (easy-menu-add-item): Default to the global map, as documented.
> > (easy-menu-convert-item-1): Use match-string.
> >
> > As for where it's documented: in the docstring a few lines above.
> > So recentf should probably not use a nil MAP if it wants to use
> > the local map.
> > Or should we change the doc instead ?
>
> The change to `easy-menu-add-item' causes trouble with info and
> calendar, and also with external libraries like emacs-w3m. Reversion
> superficially avoids that trouble, but I don't really grok easymenu.
> Maybe it is easier to change the doc instead if there are many callers
> to fix.
I've been looking at what the XEmacs version does (since compatibility
is the whole point of easymenu) and there a nil MAP (which they call
MENU) means "use the current menu" which actually means use the menu
in the `current-menubar' which can be made a buffer-local variable,
but not necessarily.
Admittedly, it is almost always buffer-local, so I think you're
right that it's better to change the docstring and revert my patch
to the code.
But then it seems that easy-menu offers no way to portably add
a global menu.
Stefan
next prev parent reply other threads:[~2003-03-22 22:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <m3adfri8kz.fsf@defun.localdomain>
2003-03-19 19:33 ` [calendar] Holidays menu doesn't go away John Paul Wallington
2003-03-20 2:36 ` John Paul Wallington
2003-03-22 21:39 ` Stefan Monnier
2003-03-22 22:14 ` John Paul Wallington
2003-03-22 22:30 ` Stefan Monnier [this message]
2003-03-24 2:05 ` Richard Stallman
2003-03-24 15:10 ` Stefan Monnier
2003-03-25 0:52 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200303222230.h2MMUf8B032565@rum.cs.yale.edu \
--to=monnier+gnu/emacs/pretest@rum.cs.yale.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.